Repository navigation
Update Load8 with GatherVector256 instruction for .NET Core 3 - #1200
Merged
Merged
Conversation
added 2 commits
October 9, 2018 11:38
eerhardt
reviewed
Oct 9, 2018
| if (Avx2.IsSupported) | ||
| { | ||
| Vector256<int> idx256 = Avx.LoadVector256(idx); | ||
| return Avx2.GatherVector256(src, idx256, 4); |
Member
There was a problem hiding this comment.
(nit) I think it makes for more readable code if you name the parameter:
return Avx2.GatherVector256(src, idx256, scale: 4);
eerhardt
approved these changes
Oct 9, 2018
Member
|
@helloguo thank was quick! big thanks for doing this! do you have any ideas for improving the perf of |
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Load8 with GatherVector256 instruction for .NET Core 3. Fix #1195
Before the change:

After the change:

cc\ @adamsitnik @eerhardt