Skip to content

Sweepable Parameter can't handle Russia Format #4634

Closed

Description

@LittleLittleCloud

If, for example, in SweepableFloatParam, the raw text value is 0,00123454, it will be parsed into 123454 instead of 0.00123454

See this Issue for further details

Activity

  1. justinormont commented on Jan 7, 2020

    @justinormont
    Contributor

    I would fix by pushing a culture invariant into the sweepable param:

    _valueText = _value.ToString("R");

  2. LittleLittleCloud commented on Jan 8, 2020

    @LittleLittleCloud
    MemberAuthor

    In that case we need to add culture invariant to whichever parse from /into string in AutoML. Either we stick to one culture preference inside AutoML, or we just use the default culture setting.

    Do you remember the story why we add that culture invariant restriction when parsing sweepable params..

  3. justinormont commented on Jan 8, 2020

    @justinormont
    Contributor

    I would stick w/ culture invariant for the lifetime of the string. Currently we have culture invariant on the use of the string, but not the creation. Hence this issue being filed.

    Using culture invariant helps in various ways:

    • If we separate the run context (e.g. cluster sweeping) the remote runner machines may be set to English/Russian/etc and needs to share sweep values.
    • Logging -- lets say we want to aggregate and find the best values for a hyperparamer like LearningRate. We'll be receiving values of 0.1234 and 0,1234.
  4. LittleLittleCloud commented on Jan 9, 2020

    @LittleLittleCloud
    MemberAuthor

    OK that's convincing, thanks

  5. ghost locked as resolved and limited conversation to collaborators on Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions