You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IDataView Type system needs to be extensible to properly support image, date, and other types #3274
To support loading Image from IDataView (as shown in #3263), user must modify ML.NET code, which means our type system is not extensive. Do we want to invest on the extensibility of ML.NET type system?
Perhaps we ought to change this to, the reflection based mechanism by which things like prediction engine specifically are not extensible to new types -- a problem that would not exist but for the fact that the DataView type system is extensible, which makes the title a bit misleading? What you think?
I also I have a possibly workable solution to that specific problem in #3263, let me know your reactions.
changed the title [-]DataView Type System Is Not Extensive Enough[/-][+]DataView Type system needs to be extensible to properly support image, date and 3rd-party data types[/+]on May 14, 2019
changed the title [-]DataView Type system needs to be extensible to properly support image, date and 3rd-party data types[/-][+]IDataView Type system needs to be extensible to properly support image, date and other additional types[/+]on May 14, 2019
changed the title [-]IDataView Type system needs to be extensible to properly support image, date and other additional types[/-][+]IDataView Type system needs to be extensible to properly support image, date, and other types[/+]on May 14, 2019
Agree. I think this is "a must" feature (pre-requisite) in ML.NET (support for in-memory images) in order to be able to release the TensorFlow and ONNX packages as v1.0 (Currently 0.12).
Note that this implementation would be centralized (not specific within the TensorFlow or ONNX packages), though, so it'll need a new version for ML.NET itself, too? Minor version?
Activity
TomFinley commentedon Apr 10, 2019
Perhaps we ought to change this to, the reflection based mechanism by which things like prediction engine specifically are not extensible to new types -- a problem that would not exist but for the fact that the DataView type system is extensible, which makes the title a bit misleading? What you think?
I also I have a possibly workable solution to that specific problem in #3263, let me know your reactions.
[-]DataView Type System Is Not Extensive Enough[/-][+]DataView Type system needs to be extensible to properly support image, date and 3rd-party data types[/+][-]DataView Type system needs to be extensible to properly support image, date and 3rd-party data types[/-][+]IDataView Type system needs to be extensible to properly support image, date and other additional types[/+][-]IDataView Type system needs to be extensible to properly support image, date and other additional types[/-][+]IDataView Type system needs to be extensible to properly support image, date, and other types[/+]CESARDELATORRE commentedon May 14, 2019
Agree. I think this is "a must" feature (pre-requisite) in ML.NET (support for in-memory images) in order to be able to release the TensorFlow and ONNX packages as v1.0 (Currently 0.12).
Note that this implementation would be centralized (not specific within the TensorFlow or ONNX packages), though, so it'll need a new version for ML.NET itself, too? Minor version?