Skip to content

substitute AlignedArray with a regular array #1018

Closed

Description

@Anipik

This issue tracks the progress with removing the aligned array.

The aligned array wont make much difference here as we do a lot of move operation.

More Discussion #383

Rough Implementation :- https://github.com/Anipik/machinelearning/tree/temp

This branch removes all the aligned array code from src as well as implementation. All the tests are passing
Will update the issue with performance numbers soon

cc @danmosemsft @tannergooding @TomFinley @eerhardt

Activity

  1. wschin commented on Oct 12, 2018

    @wschin
    Contributor

    What kind of perf do you want to have? How large the data sets are being targeted? For large-scale ML, one representative example is training FFM (a user of AlignedArray) on Criteo. Could you give it a try with your changes? Thanks.

  2. artidoro commented on Oct 27, 2018

    @artidoro
    Contributor

    @Anipik was this issue solved with #1274?

  3. Anipik commented on Oct 28, 2018

    @Anipik
    ContributorAuthor

    no its yet to be completed

  4. added this to the 1118 milestone on Nov 19, 2018
  5. ghost locked as resolved and limited conversation to collaborators on Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions