Revert non-determinism in Nuget local sources - #19074
Merged
Merged
Conversation
ViktorHofer
approved these changes
Mar 16, 2024
This was referenced Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary solution for dotnet/source-build#4206
NuGet/NuGet.Client@f54c58f introduced non-determinism in restoring packages from local package sources. Previously, local sources were used in order they were specified in
NuGet.config. This is not the case anymore.This fix is a revert of the change.
Long-term solution involves the use of package source mappings, and will be ready for Preview 4.
Validation builds:
dotnet-source-build-lite- https://dev.azure.com/dnceng/internal/_build/results?buildId=2406188&view=resultsdotnet-source-build- https://dev.azure.com/dnceng/internal/_build/results?buildId=2406189&view=results