Skip to content

Name resolution environment captures last ident range instead of full range in long ident - #3922

Closed
vasily-kirichenko wants to merge 5 commits into
dotnet:masterfrom
vasily-kirichenko:fix-long-ident-range
Closed

vasily-kirichenko wants to merge 5 commits into
dotnet:masterfrom
vasily-kirichenko:fix-long-ident-range

Conversation

@vasily-kirichenko

Copy link
Copy Markdown
Contributor

For

module M =
    let _x = System.Collections.Generic.List<int>()

[<EntryPoint>]
let main argv = 
    0

image

@vasily-kirichenko

vasily-kirichenko commented Nov 10, 2017 •

Copy link
Copy Markdown
Contributor Author

The CI does not trigger. @cartermp @KevinRansom @brettfo

@brettfo

brettfo commented Nov 10, 2017

Copy link
Copy Markdown
Member

All of our (our = F# + dotnet + others) Jenkins machines are currently down; it's being worked on, but I haven't heard an ETA yet.

@vasily-kirichenko

Copy link
Copy Markdown
Contributor Author

@dotnet-bot test this please

@TIHan

TIHan commented Nov 30, 2017

Copy link
Copy Markdown
Contributor

@dotnet-bot test this please

1 similar comment
@cartermp

cartermp commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

@dotnet-bot test this please

@cartermp

cartermp commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

Also, conflicts

@vasily-kirichenko

Copy link
Copy Markdown
Contributor Author

It’s not finished. @auduchinok promised to work on it.

# Conflicts:
#	tests/service/ProjectAnalysisTests.fs
@KevinRansom

Copy link
Copy Markdown
Contributor

@auduchinok is this something you are interested in finishing off?

@KevinRansom

Copy link
Copy Markdown
Contributor

This is a promising work item, however, we are trying to reduce the number of PRs that seem to have been abandoned.

Please reopen or resubmit, when you feel that you are able to complete the work.

Thank you,

Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants