Repository navigation
[release/dev17.13] Migrate internal tools feed authentication to WIF - #20579
Merged
Merged
Conversation
Replace the PAT-backed NuGet service connection with the workload identity service connection for the devdiv internal tooling feed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3ee73e53-8098-4533-b3f9-1686640d4f55
github-actions
Bot
added
⚠️ Affects-Build-Infra
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Restore
|
Member
Author
|
@dotnet/fsharp-team-msft Hey folks, looks like there's some errors on this branch, too, that are preventing this PR from successfully building. Could someone please take a look? Thanks! |
Member
|
/azp run fsharp-ci |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Use the existing native-tools installer only for the QA matrix entry. The current Windows image cannot launch perl.exe, so the harness never starts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add the existing quiet console logger to mock design-time builds. Release failures currently expose only empty references and flags, without the underlying MSBuild error. This is a diagnostic probe, not a test assertion repair. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Update only VisualFSharp.UnitTests private MSBuild packages and their required dependencies. Installed VS targets pass EnableCustomCulture, which the older test-local ResolveAssemblyReference task cannot accept. Remove the temporary diagnostic logger. Product package pins and test assertions stay unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Merge the test runtime binding suggestions into the copied fsc.exe.config after output files are copied. Preserve compiler runtime settings and leave the product configuration unchanged. This repairs child compiler binding failures introduced by the private test dependency alignment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Generate the test compiler redirects once from the compiler supported-runtime configuration before automatic redirects are added. This preserves startup and GC settings without overlapping generated redirects or suppressing warnings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Oct 8, 2026
T-Gro
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the PAT-backed
devdiv/dotnet-core-internal-toolingNuGet service connection ineng/restore-internal-tools.ymlwith the existing WIF service connection and explicit feed URL.Validation
eng/restore-internal-tools.yml.mainin Migrate devdiv/dotnet-core-internal-tooling to WIF service connection #20036.git diff --checkpasses.Tracks AB#12800.