Bulk codefixes are broken #14967

Activity

1. psfinaki

   added

   Bug

   Area-VS-EditorVS editor support for F# code, not covered elsewhereVS editor support for F# code, not covered elsewhere

   Needs-Triage

   on Mar 23, 2023
2. github-actions

   added this to the Backlog milestone on Mar 23, 2023
3. vzarytovskii

   added this to F# Compiler and Toolingon Mar 23, 2023
4. github-project-automation

   moved this to Not Planned in F# Compiler and Toolingon Mar 23, 2023
5. T-Gro commented on Mar 23, 2023

   

   T-Gro

   on Mar 23, 2023

   Member

   More actions

   Found something in the docs and we do not seem to use it centrally.

   namespace Microsoft.CodeAnalysis.CodeFixes
   
   open Microsoft.CodeAnalysis.CodeFixes
   
   
   ///<summary>
   ///            Implement this type to provide fixes for source code problems.
   ///            Remember to use <see cref="T:Microsoft.CodeAnalysis.CodeFixes.ExportCodeFixProviderAttribute" /> so the host environment can offer your fixes in a UI.
   ///            </summary>
   type CodeFixProvider =
     
     new: unit -> unit
     
     member ComputeRequestPriority: unit -> Microsoft.CodeAnalysis.CodeActions.CodeActionRequestPriority
     
     ///<summary>
     ///            Gets an optional <see cref="T:Microsoft.CodeAnalysis.CodeFixes.FixAllProvider" /> that can fix all/multiple occurrences of diagnostics fixed by this code fix provider.
     ///            Return null if the provider doesn't support fix all/multiple occurrences.
     ///            Otherwise, you can return any of the well known fix all providers from <see cref="T:Microsoft.CodeAnalysis.CodeFixes.WellKnownFixAllProviders" /> or implement your own fix all provider.
     ///            </summary>
     member GetFixAllProvider: unit -> FixAllProvider

   The unused opens uses a wellknown batch provider, which has limitation in it's remarks which causes the unused opens to not work.
   I have a feeling that the limitation might have been added later after F# implemented this codefix.. ?

   ///<summary>
   ///            Contains well known implementations of <see cref="T:Microsoft.CodeAnalysis.CodeFixes.FixAllProvider" />.
   ///            </summary>
   type WellKnownFixAllProviders =
     
     ///<summary>
     ///            Default batch fix all provider.
     ///            This provider batches all the individual diagnostic fixes across the scope of fix all action,
     ///            computes fixes in parallel and then merges all the non-conflicting fixes into a single fix all code action.
     ///            This fixer supports fixes for the following fix all scopes:
     ///            <see cref="F:Microsoft.CodeAnalysis.CodeFixes.FixAllScope.Document" />, <see cref="F:Microsoft.CodeAnalysis.CodeFixes.FixAllScope.Project" />, <see cref="F:Microsoft.CodeAnalysis.CodeFixes.FixAllScope.Solution" /><see cref="F:Microsoft.CodeAnalysis.CodeFixes.FixAllScope.ContainingMember" /> and <see cref="F:Microsoft.CodeAnalysis.CodeFixes.FixAllScope.ContainingType" />.
     ///            </summary>
     ///<remarks>
     ///            The batch fix all provider only batches operations (i.e. <see cref="T:Microsoft.CodeAnalysis.CodeActions.CodeActionOperation" />) of type
     ///            <see cref="T:Microsoft.CodeAnalysis.CodeActions.ApplyChangesOperation" /> present within the individual diagnostic fixes. Other types of
     ///            operations present within these fixes are ignored.
     ///            </remarks>
     static member BatchFixer: FixAllProvider
6. T-Gro

   self-assigned this

   on Mar 23, 2023
7. 0101 commented on Mar 27, 2023

   

   0101

   on Mar 27, 2023

   Contributor

   More actions

   Duplicate of #14864
8. 0101

   marked this as a duplicate of Visual Studio 17.5 F# Remove unused open declarations does not work for Document, Projec,t or Solution #14864 on Mar 27, 2023
9. 0101

   closed this as completedon Mar 27, 2023
10. github-project-automation

    moved this from Not Planned to Done in F# Compiler and Toolingon Mar 27, 2023
11. psfinaki

    added

    Area-LangService-CodeFixesCode fixes associated with diagnosticsCode fixes associated with diagnostics

    and removed

    Needs-Triage

    on Jun 15, 2023