Skip to content

Don't show parameter name hints when they coincide with argument names #14447

Closed

Description

@psfinaki

Arguably, those rather clutter the editor view than benefit it.

Compare with C#:
image

I believe even in our codebase that would be quite helpful:

image

Activity

  1. added this to the Backlog milestone on Dec 7, 2022
  2. 0101 commented on Dec 7, 2022

    @0101
    Contributor

    So what should it do in the example with TypeCheckInfo? Just show _sTcConfig = and g =? Should there be a special case when some parameters are named the same and a vertical layout like that is used?

  3. baronfel commented on Dec 7, 2022

    @baronfel
    Member

    We do a bunch of heuristics like this in FSAC that are inspired by rust-analyzer. Check out ionide/FsAutoComplete#932 and ionide/FsAutoComplete#935 for the complete set, but we do prefix/postfix matching, length minimums, etc, that include some of what you're talking about here.

  4. psfinaki commented on Dec 7, 2022

    @psfinaki
    ContributorAuthor

    Well I would be probably fine starting dumb, like just looking for a 100% match, so yeah it would be _sTcConfig = and g = in the example above.

    But I don't have a strong opinion, just noticed this C# behavior and decided to open a discussion on this.

  5. self-assigned this
    on Jan 9, 2023
  6. modified the milestones: Backlog, January-2023 on Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions