Skip to content

fix reference enum field - Part 5 - #3094

Merged
rpetrusha merged 5 commits into
dotnet:masterfrom
mairaw:enum-fields-5
Aug 29, 2019
Merged

rpetrusha merged 5 commits into
dotnet:masterfrom
mairaw:enum-fields-5

Conversation

@mairaw

@mairaw mairaw commented Aug 27, 2019 •

Copy link
Copy Markdown
Contributor

Went through the files 121+ of PR #1641, reviewed them and brought just the files and changes needed.

@rpetrusha for DateTimeOffset, you might wanna double check I didn't miss any other changes. I checked and thought that only the small change I brought was valid, but wasn't 100% sure.

This wraps up the work for the enum fields as captured by that PR.

Contributes to dotnet/docs#2037

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Aug 27, 2019
@mairaw mairaw added this to the August 2019 milestone Aug 27, 2019
@mairaw mairaw self-assigned this Aug 27, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments and a number of suggestions, @mairaw. You can merge when you're ready.

Comment thread xml/System.Windows.Media/EdgeMode.xml Resolved
Comment thread xml/System.Windows.Media/EdgeMode.xml Resolved
Comment thread xml/System/Base64FormattingOptions.xml Resolved
Comment thread xml/System/LoaderOptimization.xml Resolved
Comment thread xml/System/LoaderOptimization.xml Resolved
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Comment thread xml/System.Windows/MessageBoxButton.xml Resolved
Comment thread xml/System.Windows/MessageBoxButton.xml Resolved
Comment thread xml/System.Windows/MessageBoxButton.xml Resolved
@rpetrusha
rpetrusha merged commit a4d0540 into dotnet:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants