Skip to content

fix reference enum field - Part 2 - #3069

Merged
mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields-2
Aug 23, 2019
Merged

mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields-2

Conversation

@mairaw

@mairaw mairaw commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Went through the files 31-60 of PR #1641, reviewed them and brought just the files and changes needed.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Aug 23, 2019
@mairaw mairaw added this to the August 2019 milestone Aug 23, 2019
@mairaw
mairaw requested a review from karelz as a code owner August 23, 2019 04:34
@mairaw mairaw self-assigned this Aug 23, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of suggestions, @mairaw. They include fixes for the two broken xrefs reported in the build report.

Comment thread xml/System.Net.Sockets/SocketFlags.xml Resolved
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@mairaw

mairaw commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

As usual, very thorough review @rpetrusha! Thanks so much. I've accepted all your edits.

@mairaw
mairaw merged commit 028e726 into dotnet:master Aug 23, 2019
@mairaw
mairaw deleted the enum-fields-2 branch August 23, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants