Skip to content

fix reference enum field - Part 1 - #3068

Merged
mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields
Aug 24, 2019
Merged

mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields

Conversation

@mairaw

@mairaw mairaw commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Went through the first 30 files of PR #1641, reviewed them and brought just the files and changes needed.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Aug 23, 2019
@mairaw mairaw added this to the August 2019 milestone Aug 23, 2019
@mairaw
mairaw requested a review from stevestein as a code owner August 23, 2019 00:58
@mairaw mairaw self-assigned this Aug 23, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @mairaw. I've left a number of suggestions for you to consider, along with a comment.

Comment thread xml/System.Data/CommandType.xml Resolved
Comment thread xml/System.Data/CommandType.xml Resolved
Comment thread xml/System.Data/CommandType.xml Resolved
Comment thread xml/System.IO.Pipes/PipeDirection.xml Resolved
Comment thread xml/System.IO.Ports/SerialData.xml Resolved
Comment thread xml/System.IO.Ports/SerialError.xml Resolved
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@mairaw

mairaw commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

Thanks again for the awesome review. Should we file an issue for the enum thing? It might be hard to find those though.

@mairaw
mairaw merged commit fd22f78 into dotnet:master Aug 24, 2019
@mairaw
mairaw deleted the enum-fields branch August 24, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants