Skip to content

Update NTAccount.xml - #2740

Closed
lennybacon wants to merge 2 commits into
dotnet:masterfrom
lennybacon:patch-1
Closed

lennybacon wants to merge 2 commits into
dotnet:masterfrom
lennybacon:patch-1

Conversation

@lennybacon

Copy link
Copy Markdown
Contributor
  • Fixed the wrong uppercase. Just run the following powershell Foreach($group in [System.Security.Principal.WindowsIdentity]::GetCurrent().Groups){ $group.Translate([System.Security.Principal.NTAccount]) } and you'll see for example BUILTIN\Users which is NOT uppercase.
  • Added the information about the pre-Windows 2000 name is active directory scenarios.
  • Added a hint on how to resolve the real name is active directory scenarios.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

- Fixed the wrong **uppercase**. Just run the following powershell `Foreach($group in [System.Security.Principal.WindowsIdentity]::GetCurrent().Groups){ $group.Translate([System.Security.Principal.NTAccount]) }` and you'll see for example `BUILTIN\Users` which is NOT uppercase.
- Added the information about the **pre-Windows 2000 name** is active directory scenarios.
- Added a hint on how to resolve the real **name** is active directory scenarios.
@BillWagner BillWagner added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jul 12, 2019
@mairaw

mairaw commented Jul 20, 2019

Copy link
Copy Markdown
Contributor

Thanks for your PR @lennybacon! @bartonjs, @GrabYourPitchforks can you please review this PR for NTAccount class?

@mairaw mairaw added the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 20, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 20, 2019

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we wait for the tech review, I've left some suggestions on grammar and formatting.

@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 20, 2019

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bartonjs for the review. Let's just implement the suggestions and this should be good to merge.

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@lennybacon lennybacon closed this Jul 20, 2019
@lennybacon

Copy link
Copy Markdown
Contributor Author

@mairaw any idea when the merge is done?

@lennybacon lennybacon mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants