Repository navigation
AssemblyLoadContext unloadability documentation - #1975
Conversation
| <summary>To be added.</summary> | ||
| <summary>Is Assembly held in a collectible AssemblyLoadContext?</summary> | ||
| <value>To be added.</value> | ||
| <remarks>To be added.</remarks> |
There was a problem hiding this comment.
it would be helpful to add a remark that explains what a collectible assembly load context is.
There was a problem hiding this comment.
I drafted the remarks
Update xml/System.Reflection/MemberInfo.xml Update xml/System.Runtime.Loader/AssemblyLoadContext.xml Co-Authored-By: sdmaclea <stmaclea@microsoft.com>
|
|
||
| Care should be taken to avoid holding references in global data structures which may unintentionally prevent collection. | ||
|
|
||
| Similarly, care should also be taken to hold references when intentionally trying to prevent garbage collection. |
There was a problem hiding this comment.
@janvorli I was tempted to add a comment here that threads running in a collectible ALC should hold a reference in the stack, but I wasn't sure what the guidance was supposed to be.
There was a problem hiding this comment.
I am not sure what you are trying to say. What reference they should hold in the stack?
You can take a look at my pending https://github.com/dotnet/docs/pull/10256/files, section "Troubleshoot unloadability issues" for a list of things that can hold collectible context alive.
There was a problem hiding this comment.
I just revised this to refer to your new doc. Thanks.
cae3e67 to
46595ac
Compare
|
Is this ready to merge, @sdmaclea? |
|
I just looked at the open publish results and one of the links was broken. I just committed the fix. It should be ready to merge as long as that link is valid (it is used in 4 places). |
|
Thanks, @sdmaclea. I should have thought of looking at the build report! |
|
The build finished. The broken link warning is gone, but openpublish.build doesn't seem to have published the files. For instance https://review.docs.microsoft.com/en-us/system.runtime.loader.assemblyloadcontext?branch=pr-en-us-1975&view=netcore-3.0 gives a 404. |
Summary
Document AssemblyLoadContext unloadability added for .NET Core 3.0
Fixes #1717
/cc @janvorli