Skip to content

Add some AssemblyLoadContext documentation - #1353

Merged
rpetrusha merged 4 commits into
dotnet:masterfrom
sdmaclea:appDomain
Dec 14, 2018
Merged

rpetrusha merged 4 commits into
dotnet:masterfrom
sdmaclea:appDomain

Conversation

@sdmaclea

@sdmaclea sdmaclea commented Dec 12, 2018 •

Copy link
Copy Markdown
Contributor

Summary

Add some AssemblyLoadContext documentation
Fix AppDomain typo
Add System.Runtime.Loader summary

Initial attempt to fix #1129
Fixes #785

@sdmaclea

Copy link
Copy Markdown
Contributor Author

This is a first pass at this documentation. It should be reasonably accurate.

  • The unmanaged and profiling APIs are still largely undocumented.
  • The references to general guidance and instructive documents is missing (because they mostly do not yet exist).
  • There is a general lack of examples.

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see some details for AssemblyLoadContext

Fix AppDomain typo
Add System.Runtime.Loader summary

@swaroop-sridhar swaroop-sridhar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the documentation for ALC. I agree with your PR notes that we need more explanation and samples. I left some comments and suggestions. The changes looks good once they are addressed.

@sdmaclea
sdmaclea force-pushed the appDomain branch 2 times, most recently from e3fce56 to a3c42f7 Compare December 13, 2018 04:01
@sdmaclea

Copy link
Copy Markdown
Contributor Author

I have addressed all feedback. The openpublishbuild completed without any new warnings. I am happy with the published results so far.

@rpetrusha PTAL when you get a chance

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general - several nits and comments.

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for documenting these APIs, @sdmaclea. I've left a number of suggestions for changes, as well as a few comments.

Comment thread xml/ns-System.Runtime.Loader.xml Resolved
@sdmaclea

Copy link
Copy Markdown
Contributor Author

I have tried to address all the feedback. Waiting for the build to complete to take a look again.

@sdmaclea
sdmaclea force-pushed the appDomain branch 4 times, most recently from f039acf to f799cc9 Compare December 14, 2018 02:57
@sdmaclea

Copy link
Copy Markdown
Contributor Author

@rpetrusha

Copy link
Copy Markdown

@sdmaclea, %2A means that the method name will be displayed without parameters, and that, if the method is overloaded, the link resolves to the top of the page (with the overload list) rather than to a specific overload.

@rpetrusha

Copy link
Copy Markdown

This looks good, @sdmaclea. I'll merge your PR now. Hopefully, it will be live tomorrow.

@rpetrusha
rpetrusha merged commit b3c4d0d into dotnet:master Dec 14, 2018
@sdmaclea

Copy link
Copy Markdown
Contributor Author

@rpetrusha Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document System.​Runtime.​Loader Namespace Empty

6 participants