Skip to content

Revised conditional logical operators articles - #8880

Merged
BillWagner merged 4 commits into
dotnet:masterfrom
pkulikov:revise-conditional-logical-operators
Nov 6, 2018
Merged

BillWagner merged 4 commits into
dotnet:masterfrom
pkulikov:revise-conditional-logical-operators

Conversation

@pkulikov

@pkulikov pkulikov commented Nov 5, 2018

Copy link
Copy Markdown
Contributor

The code examples are much shortened and moved to the samples repo: dotnet/samples#442

@pkulikov
pkulikov requested a review from BillWagner as a code owner November 5, 2018 21:24
@pkulikov pkulikov changed the title Revised conditional logical operators articles WIP Revised conditional logical operators articles Nov 5, 2018
@pkulikov pkulikov changed the title WIP Revised conditional logical operators articles Revised conditional logical operators articles Nov 5, 2018
@pkulikov pkulikov changed the title Revised conditional logical operators articles WIP Revised conditional logical operators articles Nov 6, 2018
@pkulikov pkulikov changed the title WIP Revised conditional logical operators articles Revised conditional logical operators articles Nov 6, 2018
@rpetrusha

Copy link
Copy Markdown
Contributor

Closing and opening to begin new build.

@rpetrusha rpetrusha closed this Nov 6, 2018
@rpetrusha rpetrusha reopened this Nov 6, 2018
@rpetrusha
rpetrusha self-requested a review November 6, 2018 18:50

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @pkulikov

I had one small text suggestion, because C# 7.0 has been around for a while. 😄

Once you make that change, I'll :shipit:

@rpetrusha
rpetrusha removed their request for review November 6, 2018 18:55
@pkulikov

pkulikov commented Nov 6, 2018

Copy link
Copy Markdown
Contributor Author

@BillWagner thanks, I've addressed your feedback. Also updated the same note in the article about the ~ operator, in which tweaked the first sentence a bit, as well.

@BillWagner
BillWagner merged commit 65c9a1e into dotnet:master Nov 6, 2018
@pkulikov
pkulikov deleted the revise-conditional-logical-operators branch November 6, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants