Clarify HttpClient connection-pool disposal - #55318
Merged
Merged
Conversation
Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix misleading instruction about HttpClient disposal
Clarify HttpClient connection-pool disposal
Aug 5, 2026
adegeo
marked this pull request as ready for review
August 5, 2026 22:19
MihaZupan
approved these changes
Aug 5, 2026
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
adegeo
enabled auto-merge (squash)
August 5, 2026 23:26
MihaZupan
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpClientdisposal doesn't always dispose pooled connections. The outcome depends on whether the client owns its underlying handler.Connection pool ownership
HttpClientdisposes pooled connections only when it also disposes its handler.Factory-managed clients
IHttpClientFactorymanages and reuses handlers and their connection pools.Internal previews