Skip to content

Added two Visual Basic command-line switches - #4733

Merged
rpetrusha merged 6 commits into
dotnet:masterfrom
rpetrusha:switches
Mar 22, 2018
Merged

rpetrusha merged 6 commits into
dotnet:masterfrom
rpetrusha:switches

Conversation

@rpetrusha

Copy link
Copy Markdown
Contributor

Added two Visual Basic command-line switches

Fixes #3829

//cc @BillWagner

@rpetrusha
rpetrusha requested a review from BillWagner March 22, 2018 00:20

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

I made notes where you could include the new compiler-options.md file.

Other than those small nits, :shipit: when you are readyl.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Since we've merged the PR with the compiler-options.md file for options, do you want to use that here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference the compiler-options.md file here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference the compiler-options.md file here.

@rpetrusha rpetrusha added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Mar 22, 2018
@rpetrusha

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing this, @BillWagner. I've added the includes and will merge now.

@rpetrusha
rpetrusha merged commit d415fe1 into dotnet:master Mar 22, 2018
@rpetrusha
rpetrusha deleted the switches branch March 23, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants