Repository navigation
C13806: Potential extra character - #4715
Merged
Merged
Conversation
Hello, @mairaw, Localization team has reported source content issue that causes localized version to have broken format compared to en-us version. Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR. Many thanks in advance.
mairaw
reviewed
Mar 20, 2018
mairaw
left a comment
Contributor
There was a problem hiding this comment.
Thanks @carolinacmoravia. Changes look good but I think you'd want to apply the same change to the previous line too, no?
| @@ -228,7 +228,7 @@ This step-by-step article describes how a system administrator can deploy the [! | |||
| The following log files are generated during [!INCLUDE[net_v45](../../../includes/net-v45-md.md)] setup: | |||
|
|
|||
| %temp%\Microsoft .NET Framework 4.5*.txt | |||
Contributor
There was a problem hiding this comment.
shouldn't the same change be done here too?
Contributor
There was a problem hiding this comment.
@mairaw, the change was to remove the "" before the * character, so both lines now correspond. I think that this is OK to merge, since the build looks OK, and the log is placed in the %temp% directory, rather than in a subdirectory of %temp%.
Contributor
There was a problem hiding this comment.
good catch @rpetrusha! I was somehow looking in reverse mode.
rpetrusha
approved these changes
Mar 21, 2018
rpetrusha
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @carolinacmoravia. Your change looks good, so I'll merge your PR now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @mairaw,
Localization team has reported source content issue that causes localized version to have broken format compared to en-us version.
Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR.
Many thanks in advance.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)