Skip to content

C13806: Potential extra character - #4715

Merged
rpetrusha merged 1 commit into
dotnet:masterfrom
carolinacmoravia:patch-25
Mar 21, 2018
Merged

rpetrusha merged 1 commit into
dotnet:masterfrom
carolinacmoravia:patch-25

Conversation

@carolinacmoravia

Copy link
Copy Markdown
Contributor

Hello, @mairaw,

Localization team has reported source content issue that causes localized version to have broken format compared to en-us version.

Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR.

Many thanks in advance.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Hello, @mairaw,

Localization team has reported source content issue that causes localized version to have broken format compared to en-us version. 

Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR.

Many thanks in advance.

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carolinacmoravia. Changes look good but I think you'd want to apply the same change to the previous line too, no?

@@ -228,7 +228,7 @@ This step-by-step article describes how a system administrator can deploy the [!
The following log files are generated during [!INCLUDE[net_v45](../../../includes/net-v45-md.md)] setup:

%temp%\Microsoft .NET Framework 4.5*.txt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the same change be done here too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw, the change was to remove the "" before the * character, so both lines now correspond. I think that this is OK to merge, since the build looks OK, and the log is placed in the %temp% directory, rather than in a subdirectory of %temp%.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @rpetrusha! I was somehow looking in reverse mode.

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @carolinacmoravia. Your change looks good, so I'll merge your PR now.

@rpetrusha
rpetrusha merged commit fa101b3 into dotnet:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants