Repository navigation
SmtpClient doc correction for .net core. Fixes #4705 - #4706
Merged
Merged
Conversation
maryamariyan
force-pushed
the
fix-smtpclient
branch
from
March 20, 2018 01:37
3fa6abe to
b7c4c26
Compare
rpetrusha
suggested changes
Mar 20, 2018
rpetrusha
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding information on .NET Core, @maryamariyan. I've made a couple of comments and suggestions.
| To include an attachment with an email message, first create the attachment by using the <xref:System.Net.Mail.Attachment> class, and then add it to the message by using the <xref:System.Net.Mail.MailMessage.Attachments%2A?displayProperty=nameWithType> property. Depending on the email reader used by the recipients and the file type of the attachment, some recipients might not be able to read the attachment. For clients that cannot display the attachment in its original form, you can specify alternate views by using the <xref:System.Net.Mail.MailMessage.AlternateViews%2A?displayProperty=nameWithType> property. | ||
|
|
||
| You can use the application or machine configuration files to specify default host, port, and credentials values for all <xref:System.Net.Mail.SmtpClient> objects. For more information, see [<mailSettings> Element (Network Settings)](~/docs/framework/configure-apps/file-schema/network/mailsettings-element-network-settings.md). | ||
| In .NET Framework you can use the application or machine configuration files to specify default host, port, and credentials values for all <xref:System.Net.Mail.SmtpClient> objects. For more information, see [<mailSettings> Element (Network Settings)](~/docs/framework/configure-apps/file-schema/network/mailsettings-element-network-settings.md). But in .NET Core we don't support setting defaults. As a workaround you need to set the relevant properties on SmtpClient directly. |
Contributor
There was a problem hiding this comment.
- comma after .NET Framework
- The .NET Core sentence should be rephrased to remove "But" and "we": ".NET Core does not support setting defaults. As a workaround, you must set the relevant properties on SmtpClient directly.
- fence SmtpClient (`SmtpClient`)
Contributor
Author
There was a problem hiding this comment.
thanks @rpetrusha . How do I fence SmtpClient?
this way: SmtpClient
or
this way: < xref:System.Net.Mail.SmtpClient >
Contributor
|
Incidentally, @maryamariyan, it wasn't necessary to open an issue, since this is a minor correction. |
Contributor
|
This looks good. Thanks for making the additional changes, @maryamariyan. We'll merge now. |
rpetrusha
approved these changes
Mar 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SmtpClient doc correction for .net core.
Fixes #4705
cc: @mairaw