Skip to content

Update object-oriented-programming.md - #4702

Closed
UmorenoRamon wants to merge 1 commit into
dotnet:masterfrom
UmorenoRamon:patch-2
Closed

UmorenoRamon wants to merge 1 commit into
dotnet:masterfrom
UmorenoRamon:patch-2

Conversation

@UmorenoRamon

Copy link
Copy Markdown
Contributor

the declaration of the Generic class sample, should have the public keyword in lower case.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

the declaration of the Generic class sample, should have the public keyword in lower case.
@mairaw mairaw added ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository ✨ 1st-time GH contributor! labels Mar 20, 2018

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @UmorenoRamon! The fix looks great. While validating the fix, I also noticed that line 94 had a similar issue with an uppercase Class. Would you like to edit your PR here to submit that other change as well?

To do that, go to the Files tab (https://github.com/dotnet/docs/pull/4702/files) and click the edit button on the file (the pencil icon).

Thanks!

@BillWagner

Copy link
Copy Markdown
Member

closing this, because @UmorenoRamon made the same change in PR #4737

@BillWagner BillWagner closed this Mar 22, 2018
@mairaw mairaw added ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository and removed ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository ✨ 1st-time GH contributor! labels Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants