Skip to content

CI Update - #4689

Merged
mairaw merged 2 commits into
masterfrom
CITest
Mar 21, 2018
Merged

mairaw merged 2 commits into
masterfrom
CITest

Conversation

@dend

@dend dend commented Mar 16, 2018

Copy link
Copy Markdown
Contributor

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@mairaw

mairaw commented Mar 16, 2018

Copy link
Copy Markdown
Contributor

@dend selecting a different language on the API is not making the syntax switch the language.
e.g. https://review.docs.microsoft.com/en-us/dotnet/api/system.string?view=netframework-4.7.1&branch=pr-en-us-4689

@mairaw

mairaw commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@dend I think we'll need to do a force build from the portal but I'm having issues. Can you try? The language switch is still not working for me.

@dend

dend commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

@mairaw I see that the languages now properly switch the samples, but I don't get the same behavior for signatures. Investigating.

@dend

dend commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

@mairaw kicked off a new forced build. Let's see what happens.

@mairaw

mairaw commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@dend that was the behavior last week already. I'd do a full rebuild to make sure settings are applied and such but the portal is not letting me select branches on manual publish,

@mairaw

mairaw commented Mar 19, 2018 •

Copy link
Copy Markdown
Contributor

@mairaw kicked off a new forced build. Let's see what happens.

Cool. Thanks @dend!

@mairaw

mairaw commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@dend build has finished but syntax still doesn't change when you select a different language 😢

@dend

dend commented Mar 21, 2018

Copy link
Copy Markdown
Contributor Author

@mairaw following up on a separate internal thread to diagnose the root cause of the issue.

@mairaw

mairaw commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

@rpetrusha and I decided we were going to merge this since this solves a bunch of broken links and we'll see the behavior on production. Not having the switch working is no different than the current behavior.

@mairaw
mairaw merged commit 081e916 into master Mar 21, 2018
@mairaw
mairaw deleted the CITest branch March 21, 2018 23:12
@dend

dend commented Mar 22, 2018

Copy link
Copy Markdown
Contributor Author

@mairaw I see that there is still no change. I kicked off a force build on master. Otherwise, we'll need to escalate.

@dotnet-policy-service dotnet-policy-service Bot added the in-pr This issue will be closed (fixed) by an active pull request. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-pr This issue will be closed (fixed) by an active pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants