Repository navigation
Change VB compiler switch from \ to - - #4632
Conversation
|
I gave this a quick look, but not a super thorough read. Let me know when it's ready for a full review. One comment is that we should add a statement that both Should that also be an include file so it appears on each option page? If you think so, I'll update the C# ones. |
BillWagner
left a comment
There was a problem hiding this comment.
A very thorough update @rpetrusha Thanks for all the work.
I'm going to approve this, but you should fix the URL and other typos I found. After that,
!
|
|
||
| > [!NOTE] | ||
| > We recommend that you always consider security implications when creating an XML Web service. For information on securing an XML Web service, see [Securing XML Web Services Created Using ASP.NET](http://msdn.microsoft.com/library/354b2ab1-2782-4542-b32a-dc560178b90c). | ||
| > We recommend that you always consider security implications when creating an XML Web service. For information on securing an XML Web service, see [Securing XML Web Services Created Using ASP.NET](http://msdn.microsoft.com-library/354b2ab1-2782-4542-b32a-dc560178b90c). |
There was a problem hiding this comment.
"msdn.microsoft.com-library" should not have changed from "msdn.microsoft.com/library"
| [Updating Data Sources with DataAdapters](../../../../../docs/framework/data/adonet/updating-data-sources-with-dataadapters.md) | ||
| [DataAdapter Parameters](../../../../../docs/framework/data/adonet/dataadapter-parameters.md) | ||
| [Web Services Description Language Tool (Wsdl.exe)](http://msdn.microsoft.com/library/b9210348-8bc2-4367-8c91-d1a04b403e88) | ||
| [Web Services Description Language Tool (Wsdl.exe)](http://msdn.microsoft.com-library/b9210348-8bc2-4367-8c91-d1a04b403e88) |
There was a problem hiding this comment.
another path change ".com-library" => ".com/library"
| 1. Apply the <xref:System.STAThreadAttribute> to the C# `Main` method to specify your Windows Forms application is a single-threaded apartment. (The attribute is not necessary in Visual Basic, since Windows forms applications developed with Visual Basic use a single-threaded apartment model by default.) | ||
|
|
||
| 2. Call <xref:System.Windows.Forms.Application.EnableVisualStyles%2A> to give a Windows XP appearance to your application. | ||
| 2. Call <xref:System.Windows.Forms.Application.EnableVisualStyles%2A> to apply operating system styles to your application. |
There was a problem hiding this comment.
I laughed here. Good change.
|
|
||
| ## Remarks | ||
| The compiler processes the `/moduleassemblyname` option only if the `/target:module` option has been specified. This causes the compiler to create a module. The module created by the compiler is valid only for the assembly specified with the `/moduleassemblyname` option. If you place the module in a different assembly, run-time errors will occur. | ||
| The compiler processes the `-modulleassemblyname` option only if the `-target:module` option has been specified. This causes the compiler to create a module. The module created by the compiler is valid only for the assembly specified with the `-modulleassemblyname` option. If you place the module in a different assembly, run-time errors will occur. |
There was a problem hiding this comment.
typo: modulleassemblyname => moduleassemblyname
| The compiler processes the `-modulleassemblyname` option only if the `-target:module` option has been specified. This causes the compiler to create a module. The module created by the compiler is valid only for the assembly specified with the `-modulleassemblyname` option. If you place the module in a different assembly, run-time errors will occur. | ||
|
|
||
| The `/moduleassemblyname` option is needed only when the following are true: | ||
| The `-modulleassemblyname` option is needed only when the following are true: |
|
|
||
| > [!NOTE] | ||
| > The `/moduleassemblyname` option is not available from within the Visual Studio development environment; it is available only when you compile from a command prompt. | ||
| > The `-modulleassemblyname` option is not available from within the Visual Studio development environment; it is available only when you compile from a command prompt. |
|
@BillWagner, I've addressed the immediate issues you found, so I'll merge this after the build completes. But there are two issues, one that you raised and the other that I discovered:
|
Change VB compiler switch from \ to -
This PR changes VB compiler syntax to use
-rather than/as the compiler switch. I've also changed some instances of C# compiler syntax, and I've corrected some miscellaneous errors in the documentation as well.Fixes #4450
Suggested Reviewers
@BillWagner