Skip to content

Provided correct enum members, method overloads - #4484

Merged
rpetrusha merged 4 commits into
dotnet:masterfrom
rpetrusha:obsolete
Mar 15, 2018
Merged

rpetrusha merged 4 commits into
dotnet:masterfrom
rpetrusha:obsolete

Conversation

@rpetrusha

Copy link
Copy Markdown
Contributor

Provided correct enum members, method overloads

Summary

This may have been a migration problem. I've fixed two major issues:

  • A number of items in Obsolete Members in the .NET Framework referenced only the type and not the member. This was particularly true of enumeration members.
  • A number of items failed to specify the particular method overload that was deprecated.

Suggested Reviewers

@mairaw

@rpetrusha
rpetrusha requested a review from mairaw February 27, 2018 02:05
@mairaw

mairaw commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

I'll start my review. But I did double check a few in the last version before the migration and the enumeration values were there. @wh-alice @yishengjin1413 this is another topic where the enum values were not migrated properly. Is there something else we can do to cover the missed enum values? Thanks!

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha you did an excellent job on restoring some of the missing values. I carefully went through our last DDUEML version and added a few other missing ones. I'm also wondering if we should review the links which should have been autoUpgrade = false.

|<xref:System.Enum?displayProperty=nameWithType>|<xref:System.Enum.ToString%2A>|The `provider` argument is not used. Please use <xref:System.Enum.ToString%2A?displayProperty=nameWithType>.|
|<xref:System.LoaderOptimization?displayProperty=nameWithType>|<xref:System.LoaderOptimization>|This method has been deprecated. Please use <xref:System.Reflection.Assembly.Load%2A?displayProperty=nameWithType> instead.|
|<xref:System.LoaderOptimization?displayProperty=nameWithType>|<xref:System.LoaderOptimization>|This method has been deprecated. Please use <xref:System.Reflection.Assembly.Load%2A?displayProperty=nameWithType> instead.|
|<xref:System.Enum?displayProperty=nameWithType>|<xref:System.Enum.ToString(System.String,System.IFormatProvider)>|The `provider` argument is not used. Please use <xref:System.Enum.ToString%2A?displayProperty=nameWithType>.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to your change but an overall comment for some of these entries: does it make sense to link to the overload page here as the alternative? #Resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw, no it doesn't. It should link to a specific overload. I'll change these.

@@ -224,14 +224,14 @@ The tables in this article list the type members that are obsolete in the .NET F
|<xref:System.Security.Permissions.FileIOPermissionAttribute?displayProperty=nameWithType>|<xref:System.Security.Permissions.FileIOPermissionAttribute.All%2A>|Please use the <xref:System.Security.Permissions.FileIOPermissionAttribute.ViewAndModify%2A?displayProperty=nameWithType> property instead.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 204 should link to System.Security.HostSecurityManagerOptions.HostPolicyLevel #Resolved

@rpetrusha rpetrusha Mar 1, 2018 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @mairaw. #Resolved

|<xref:System.Security.Permissions.ReflectionPermissionFlag?displayProperty=nameWithType>|<xref:System.Security.Permissions.ReflectionPermissionFlag>|This permission has been deprecated. The <xref:System.Security.Permissions.ReflectionPermissionFlag> enumeration member does not include <xref:System.Security.Permissions.ReflectionPermissionFlag>. Use <xref:System.Security.Permissions.PermissionState?displayProperty=nameWithType> to get full access.|
|<xref:System.Security.Permissions.ReflectionPermissionFlag?displayProperty=nameWithType>|<xref:System.Security.Permissions.ReflectionPermissionFlag>|This permission is no longer used by the CLR.|
|<xref:System.Security.Permissions.ReflectionPermissionFlag?displayProperty=nameWithType>|<xref:System.Security.Permissions.ReflectionPermissionFlag>|This API has been deprecated.|
|<xref:System.Security.Permissions.ReflectionPermissionFlag?displayProperty=nameWithType>|<xref:System.Security.Permissions.ReflectionPermissionFlag.AllFlags>|This permission has been deprecated. The <xref:System.Security.Permissions.ReflectionPermissionFlag> enumeration member does not include <xref:System.Security.Permissions.ReflectionPermissionFlag>. Use <xref:System.Security.Permissions.PermissionState?displayProperty=nameWithType> to get full access.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

third xref should be AllFlags too and 4th one should be System.Security.Permissions.ReflectionPermissionFlag.RestrictedMemberAccess and 5th should be System.Security.Permissions.PermissionState.Unrestricted #Resolved

|<xref:System.Security.Permissions.SecurityAction?displayProperty=nameWithType>|<xref:System.Security.Permissions.SecurityAction>|Assembly level declarative security is obsolete and is no longer enforced by the CLR by default.|
|<xref:System.Security.Permissions.SecurityAction?displayProperty=nameWithType>|<xref:System.Security.Permissions.SecurityAction>|Assembly level declarative security is obsolete and is no longer enforced by the CLR by default.|
|<xref:System.Security.Permissions.SecurityAction?displayProperty=nameWithType>|<xref:System.Security.Permissions.SecurityAction>|Assembly level declarative security is obsolete and is no longer enforced by the CLR by default.|
|<xref:System.Security.Permissions.SecurityAction?displayProperty=nameWithType>|<xref:System.Security.Permissions.SecurityAction.Deny>|<xref:System.Security.Permissions.SecurityAction> is obsolete and will be removed in a future release of the .NET Framework.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd xref link should be Deny too #Resolved

|Type|Member|Message|
|----------|------------|-------------|
|<xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords?displayProperty=nameWithType>|<xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords>|First deprecated in the .NET Framework 4.5.<br /><br /> Incorrect value; use <xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords> instead.|
|<xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords?displayProperty=nameWithType>|<xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords.CorrelationHint>|First deprecated in the .NET Framework 4.5.<br /><br /> Incorrect value; use <xref:System.Diagnostics.Eventing.Reader.StandardEventKeywords> instead.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last xref should be System.Diagnostics.Eventing.Reader.StandardEventKeywords.CorrelationHint2 #Resolved

|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess.Audit>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess.Browse>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last link should be System.Diagnostics.EventLogPermissionAccess.Administer #Resolved

|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess.Audit>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess.Browse>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|
|<xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType>|<xref:System.Diagnostics.EventLogPermissionAccess.Instrument>|This member has been deprecated. Please use <xref:System.Diagnostics.EventLogPermissionAccess?displayProperty=nameWithType> instead.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last link should be System.Diagnostics.EventLogPermissionAccess.Write #Resolved

@@ -551,7 +551,7 @@ The tables in this article list the type members that are obsolete in the .NET F
|<xref:System.Net.HttpWebRequest?displayProperty=nameWithType>|<xref:System.Net.HttpWebRequest.%23ctor>|First deprecated in the .NET Framework 4.5.<br /><br /> Use of this member generates a compiler error.<br /><br /> This API supports the .NET Framework infrastructure and is not intended to be used directly from your code.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 530 - second xref link should be System.Diagnostics.PerformanceCounterPermissionAccess.Browse and second xref link should be System.Diagnostics.PerformanceCounterPermissionAccess.Read

line 531 - second xref link should be System.Diagnostics.PerformanceCounterPermissionAccess.Instrument and second xref link should be System.Diagnostics.PerformanceCounterPermissionAccess.Write
#Resolved

@@ -710,8 +710,8 @@ The tables in this article list the type members that are obsolete in the .NET F

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 688 - second xref link should be System.Windows.Forms.AccessibleStates.Valid #Resolved

|----------|------------|-------------|
|<xref:System.Xml.ValidationType?displayProperty=nameWithType>|<xref:System.Xml.ValidationType>|Validation type should be specified as <xref:System.Xml.ValidationType?displayProperty=nameWithType> or <xref:System.Xml.ValidationType?displayProperty=nameWithType>.|
|<xref:System.Xml.ValidationType?displayProperty=nameWithType>|<xref:System.Xml.ValidationType>|XDR validation through <xref:System.Xml.XmlValidatingReader?displayProperty=nameWithType> is obsoleted.|
|<xref:System.Xml.ValidationType?displayProperty=nameWithType>|<xref:System.Xml.ValidationType.Auto>|Validation type should be specified as <xref:System.Xml.ValidationType?displayProperty=nameWithType> or <xref:System.Xml.ValidationType?displayProperty=nameWithType>.|

@mairaw mairaw Feb 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd xref link should be System.Xml.ValidationType.DTD and 4th link should be System.Xml.ValidationType.Schema #Resolved

@rpetrusha

Copy link
Copy Markdown
Contributor Author

I've incorporated all of your comments, @mairaw, as well as corrected some additional issues. Thanks for doing such a thorough review!

@rpetrusha

Copy link
Copy Markdown
Contributor Author

Sorry that I missed those, @mairaw. I think I've addressed all of your comments now.

@rpetrusha
rpetrusha merged commit f7f7ca9 into dotnet:master Mar 15, 2018
luyajun0205 pushed a commit to OPS-E2E-Prod/docs that referenced this pull request Mar 19, 2018
* Fixes and improvements to Semantic analysis Get started (dotnet#4575)

* Order the definitions to match the order of terms (dotnet#4576)

The introductory sentence could be read as implying
definitions that contradict the body of the article.

* Fix invalid Windows file system paths (dotnet#4559)

* Fix invalid Windows file system paths

* Add escape characters

* Fixing capitalization of Visual Basic (dotnet#4578)

Changed "Visual basic" to "Visual Basic" for the description of the Get Visual Basic link.

* Fixed broken links in interop docs (dotnet#4573)

* Fixed broken links in interop docs

* Updated additional links

* Removed 'en-us' from URLs

* Fixing broken link to MVA course (dotnet#4580)

Visual Basic Fundamentals for Absolute Beginners link was directing to a list of courses, not really related to VB.  I've updated the link directly to the course.  I did check to see if the course was in other languages before putting in the en-US link - looks like it's available only in English.

* Minor refactoring (dotnet#4582)

Change "new ValidationResult(true, null)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.

* Fixed link (dotnet#4583)

* Update "How to: Modify string" (dotnet#4519)

* article and code moved

* interim checkin

Switching tasks.

* checkin to run test build

I want to see if I can use local functions in C# interactive.

* finish samples and new draft

Ready for my first review.

* fix build errors

* proofread

* update per feedback.

* respond to feedback.

* additional feedback.

* respond to feedback.

* Fix escape characters in HttpListener Remarks section (dotnet#4495)

* Minor refactoring (dotnet#4584)

Change "New ValidationResult(True, Nothing)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.

* fix title (dotnet#4590)

* fix broken links (dotnet#4588)

* Add the closing token for an XML include (dotnet#4593)

Without this, the rest of the file renders incorrectly.

* Correct description of ROOT parameter (dotnet#4595)

* Update tuples.md "Interoperation with C# Tuples" content (dotnet#4581)

*  Removed an excessive "and" 
*  Removed some text that didn't seem overly clear.

* Replaced link to UserVoice (dotnet#4594)

* Removed link to UserVoice

* Changed URL target

* Fix typo (dotnet#4599)

* Experiment: CodeOwners (dotnet#4597)

* Experiment: CodeOwners

Trying an experiment to see how we might use use the CODEOWNERS file to get reviews routed to the right person.

* Added several sections

* Update CODEOWNERS

* Fixing anchor link to the "private protected access modifier" section (dotnet#4601)

* fixes to the CODEOWNERS (dotnet#4602)

* fixes to the CODEOWNERS

The changes here:
1. The '@' is needed on each user name.
1. The C# Snippets was missing the 'csharp' directory component.
1. Order is important.

* Add F# guide.

* modify-string-contents.md: added interactive note (dotnet#4607)

* Fix markdown table (dotnet#4603)

Fix usage of `|` in markdown (use `&#124;` instead)

* Update infrastructure-persistence-layer-implemenation-entity-framework-core.md (dotnet#4610)

Update link to the new address to avoid an extra 301 redirect.

* csharp-interactive-note.md: style update (dotnet#4606)

* parallel-diagnostic-tools.md: removed Visual Studio version (dotnet#4608)

* adding missing language identifiers (dotnet#4611)

* adding missing language identifiers (dotnet#4612)

* adding missing language identifiers (dotnet#4613)

* adding missing language identifiers (dotnet#4614)

* adding missing language identifiers (dotnet#4615)

* adding missing language identifiers (dotnet#4616)

* adding missing language identifiers (dotnet#4617)

* adding missing language identifiers (dotnet#4618)

* adding missing language identifiers (dotnet#4619)

* adding missing language identifiers (dotnet#4620)

* adding missing language identifiers (dotnet#4621)

* adding missing language identifiers (dotnet#4622)

* adding missing language identifiers (dotnet#4623)

* Fixed some attribute names (dotnet#4629)

.NET puts the "Attribute" suffix in all its attribute *classes*, but not in the actual attribute.

* Fix "whitespace" words - docs/standard (dotnet#4605)

* base-types

* fixes by pr rpetrusha

* System.Reflection docs for ProcessorArchitecture is misleading (dotnet#4539)

* clarify the difference betwen IA64 and AMD64

* Update ProcessorArchitecture.xml

* Changed 'integer' to 'integral value' for consistency (dotnet#4586)

* 👓 sweep docset for areas where `in` wasn't mentioned but should be (dotnet#4534)

* sweep docset for areas where `in` wasn't mentioned but should be

* respond to first round of feedback

* create in-modifer article

Also, update samples and snippets and make corresponding changs to 'ref' and 'out' article.

* fix build errors

* fix one more build error

* wording change based on feedback.

* respond to edits

* commit changes from that unsaved window

Yeah, I did that. Didn't save before committing.

* added missing options (dotnet#3390)

* Add warning regarding server host configuration (dotnet#4634)

* Fix some xrefs (dotnet#4624)

* Fix some xrefs

* Fixed typo

* Change hybrid xref links to normal xrefs

* Remove redundant text with bad link

* Update compiler-api-model.md (dotnet#4636)

fix small typos

* Corrected description of verbatim attribute usage (dotnet#4635)

* removed sentence about migrating content (dotnet#4532)

* removed sentence about migrating content

* removed preview

* Update the F# Guide page and some ms.date links (dotnet#4521)

* Update to F# docs round 1

* yup

* fix

* feedback

* Fix link

* feedback

* Updates

* Updates

* Updates

* Make comments betteR

* Feedback

* Feedback

* fixes

* Improvements to Creating a Type Provider (dotnet#4592)

* Improvements to Creating a Type Provider

* Fixed assembly attribute

* Revision of DateTime.Parse overloads (dotnet#4455)

* Revision of DateTime.Parse

* Additional modifications

* Some further revisions

* Additional revisions

* Corrected bad XML tags

* Moved examples

* Additional revisions and .zip files

* Added accidentally deleted file

* Addressed review comments

* keywords/string.md: link verbatim identifier page (dotnet#4639)

* C13890: Show code for link in target versions (dotnet#4641)

Hello, @BillWagner, 

Localization team has reported source content issue that causes localized version to have broken format compared to en-us version.  

Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR. 

Many thanks in advance.

* C13891: Show code for link in target versions (dotnet#4642)

* Fix incorrect en dashes (dotnet#4644)

* replace BNF grammar with ANTL grammar (dotnet#4643)

* replace BNF grammar with ANTL grammar

The BNF grammar rendering was quite messy. Antlr provides a much more clear rendering on the current engine.

* fix typo and update metadata

* Added output comment to verbatim string code snippet (dotnet#4646)

* added missing entry (dotnet#4648)

* simplify template (dotnet#4645)

* simplify template

* feedback

* Fixed broken links to archived interop topics (dotnet#4647)

* Changed HSB to HSL color model (dotnet#4652)

* Changed HSB to HSL color model

* Addressed review comments

* Fix connect bug DevDiv # 93543 (dotnet#4653)

* fix broken link (dotnet#4655)

* Add displayProperty attribute to address customer complaint in SqlParameter.Value docs (dotnet#4660)

* Fix connect bug DevDiv # 93543

* Add clarifications to links to address DevDiv Connect Bug # 104024

* add one more displayproperty

* including the template in the treeview (dotnet#4662)

Adding reference the hierarchical template in the treeview

* Replace IIF with IF (dotnet#4665)

* Added GetHashCode() implementation to ValueObject (dotnet#4185)

This will be very helpful to readers. Picked it up from eShopOnContainers repo.

* Provided correct enum members, method overloads (dotnet#4484)

* Provided correct enum members, method overloads

* Incorporated review comments, corrected other errors

* Fixed 2 broken links

* Fixed two additional links

* Added exception information to SingleOrDefault (dotnet#4650)

* Added information on string length >= desired string length (dotnet#4651)

* Added information on string length >= desire string length

* fixed broken link

* Incorporated comments from @svick

* TLS best practices (dotnet#4658)

* IIF to IF on Tuples page (dotnet#4669)

* fix: derrived --> derived typo (dotnet#4673)

* Modified contributors guide to reflect contributors' project (dotnet#4666)

* Add link to github issue to TLS doc (dotnet#4676)

* fix link (dotnet#4672)

* fix typo (dotnet#4678)

* Remove extra backslash (dotnet#4680)

* Fix markdown link (dotnet#4679)

* Fix markdown link

* feedback

* update signalr info for 2.1 preview (dotnet#4681)

* Fix typo (dotnet#4683)

* fixed typo

* fix typo

* add PDF to preview serverless e-book (dotnet#4685)

* Removed spaces in code (dotnet#4671)

* Fixed typo in --x operator description (dotnet#4691)

* Add syntax highlighting to inline code in stackalloc (dotnet#4690)

Just noticed on docs.microsoft.com that these code blocks don't have syntax highlighting, which does not adhere to the style guide

* Add UWP as platform that supports .NET Standard (dotnet#3813)

* Add UWP as platform that supports .NET Standard

https://blogs.msdn.microsoft.com/dotnet/2017/10/10/announcing-uwp-support-for-net-standard-2-0/

* Add platforms; remove versions; add link

Instead of listing the same platforms that are listed on https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support and having to maintain both lists as new versions are released, just mention the platforms here and link to the existing table with versions.

Closes dotnet#3814

* feedback

* < and > wrong (dotnet#4664)

* < and > wrong

< and > were not in code

* Updated xref

Updated xref to correct signature

* removing tickmarks and overloads

* some other minor fixes

* Update net-standard.md (dotnet#4694)

* Correct time complexity of List<T>.InsertRange (dotnet#4693)

*  Operator new doesn't create structs on the stack  (dotnet#4667)

* Operator new doesn't create structs on the stack

* Small improvements to operator new

* Structs can contain resources too

* Mention garbage collector

* Clarified when value types are destroyed
@rpetrusha
rpetrusha deleted the obsolete branch April 3, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants