Skip to content

Update docs about Regular Expressions - #4478

Merged
rpetrusha merged 6 commits into
dotnet:masterfrom
imba-tjd:master
Feb 23, 2018
Merged

rpetrusha merged 6 commits into
dotnet:masterfrom
imba-tjd:master

Conversation

@imba-tjd

@imba-tjd imba-tjd commented Feb 23, 2018 •

Copy link
Copy Markdown
Contributor

Summary

  1. In anchors-in-regular-expressions.md, best-practices.md, details-of-regular-expression-behavior.md, grouping-constructs-in-regular-expressions.md, how-to-verify-that-strings-are-in-valid-email-format.md, quantifiers-in-regular-expressions.md, regular-expression-example-scanning-for-hrefs.md:

    • fix vertical bars between grave accent mark showing |
  2. In example2.vb and example2.cs:

    • fix quotes position
  3. In example4.vb and example4.cs:

  4. Another change in regular-expression-example-scanning-for-hrefs.md:

    • add a ul style

Details

About point 1

I refereed to https://github.com/dotnet/docs.zh-cn/blob/live/docs/standard/base-types/alternation-constructs-in-regular-expressions.md, using code tag replaced with grave accent mark.

It seems vertical bars are recognized as part of the table in markdown syntax. And this syntax is superior to the effect of grave accent mark.

About point 2

I misspelled position when I submitted the commits 😱

About point 4

I don't know whether the previous style was by design.

@dnfclas

dnfclas commented Feb 23, 2018 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Feb 23, 2018

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @imba-tjd, for contributing to the dotnet/docs repo and for spending so much time and effort in improving the regular expression documentation. Internal builds show that all of the issues you've addressed have been corrected, so we'll merge your PR now. Your changes should appear live on docs.microsoft.com in the next day or two.

@rpetrusha
rpetrusha merged commit 27e9327 into dotnet:master Feb 23, 2018
@mairaw mairaw added this to the Sprint 131 (2/3/18 - 2/23/18) milestone Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants