Repository navigation
Update docs about Regular Expressions - #4478
Merged
Merged
Conversation
accord with 5596e85
rpetrusha
approved these changes
Feb 23, 2018
rpetrusha
left a comment
Contributor
There was a problem hiding this comment.
Thank you so much, @imba-tjd, for contributing to the dotnet/docs repo and for spending so much time and effort in improving the regular expression documentation. Internal builds show that all of the issues you've addressed have been corrected, so we'll merge your PR now. Your changes should appear live on docs.microsoft.com in the next day or two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
anchors-in-regular-expressions.md,best-practices.md,details-of-regular-expression-behavior.md,grouping-constructs-in-regular-expressions.md,how-to-verify-that-strings-are-in-valid-email-format.md,quantifiers-in-regular-expressions.md,regular-expression-example-scanning-for-hrefs.md:|In
example2.vbandexample2.cs:In
example4.vbandexample4.cs:Another change in
regular-expression-example-scanning-for-hrefs.md:Details
About point 1
I refereed to https://github.com/dotnet/docs.zh-cn/blob/live/docs/standard/base-types/alternation-constructs-in-regular-expressions.md, using
codetag replaced with grave accent mark.It seems vertical bars are recognized as part of the table in markdown syntax. And this syntax is superior to the effect of grave accent mark.
About point 2
I misspelled
positionwhen I submitted the commits 😱About point 4
I don't know whether the previous style was by design.