Skip to content

AnonymousPipeServerStream.Dispose breaking change - #33784

Merged
gewarren merged 2 commits into
dotnet:mainfrom
gewarren:server-dispose
Jan 31, 2023
Merged

AnonymousPipeServerStream.Dispose breaking change#33784
gewarren merged 2 commits into
dotnet:mainfrom
gewarren:server-dispose

Conversation

@gewarren

@gewarren gewarren commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

Fixes #32713

Preview

@dotnet-bot dotnet-bot added this to the January 2023 milestone Jan 30, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Jan 30, 2023
@gewarren
gewarren requested review from a team and adamsitnik January 30, 2023 22:42

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of all the breaking change dosc @gewarren !

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren
gewarren enabled auto-merge (squash) January 31, 2023 17:55
@gewarren
gewarren merged commit 6c385cc into dotnet:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breaking change]: Changed AnonymousPipeServerStream.Dispose behaviour for HandleInheritability.Inheritable

4 participants