Skip to content

Minor fixes : inconsistent wording and some ghost characters - #3171

Merged
mairaw merged 6 commits into
dotnet:masterfrom
Styxxy:master
Sep 20, 2017
Merged

mairaw merged 6 commits into
dotnet:masterfrom
Styxxy:master

Conversation

@Styxxy

@Styxxy Styxxy commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

I fixed some some minor inconsistent use of "read-only properties" and "read only properties".
Removed some "ghost" characters.

@dnfclas

dnfclas commented Sep 18, 2017

Copy link
Copy Markdown

@Styxxy,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas

dnfclas commented Sep 18, 2017

Copy link
Copy Markdown

@Styxxy, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. The changes look great. I'm glad to see that you are contributing again.

I'll :shipit: once the build is green. It looks like the CI server did not pick this up, so I will close and reopen it to start the build again.

It should go live in a day or two.

Thanks again for contributing.

@BillWagner

Copy link
Copy Markdown
Member

closing and reopening to force the build to restart.

@BillWagner BillWagner closed this Sep 19, 2017
@BillWagner BillWagner reopened this Sep 19, 2017
@dnfclas

dnfclas commented Sep 19, 2017

Copy link
Copy Markdown

@Styxxy,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Styxxy

Styxxy commented Sep 19, 2017

Copy link
Copy Markdown
Contributor Author

@BillWagner Thanks!

@mairaw mairaw closed this Sep 20, 2017
@mairaw mairaw reopened this Sep 20, 2017
@dnfclas

dnfclas commented Sep 20, 2017

Copy link
Copy Markdown

@Styxxy,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@mairaw
mairaw merged commit 3536654 into dotnet:master Sep 20, 2017
rpetrusha pushed a commit that referenced this pull request Sep 20, 2017
* fix constructor remarks formatting. (#3141)

* fix constructor remarks formatting.

* another instance

* Update String.xml

* Update String.xml

* | didn't render to `|` properly (#3162)

* Added missing space between two words (#3161)

* M10669: Possible typo mistake: 'SC1721' (#3167)

@wiwagn,
It seems that 'SC1721' is a typo of 'CS1721'. Could you help to review this and reply, please?
Many thanks in advance!

* Update sample code for documentation VB.NET "what's new : language features : Tuples" (#3166)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* fixed broken link (#3169)

* fixed pipes in tables (#3163)

* added info about relative paths for output (#3042)

* added info about relative paths for output

* edits

* Update how-to-write-a-simple-parallel-for-loop.md (#3174)

Updated Cut to Copy in Copy/Cut and Paste this code into ...

* fixed formulas (#3182)

* fixed formulas

* fixed formula

* fixed formula

* simplifying version list (#3176)

* Minor fixes : inconsistent wording and some ghost characters (#3171)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* minor typos

* compiler warning corrected to match previously mentioned number
* removed a "ghost" quote

* fixed inconsistent "read-only" and "read only"

* code formatting (missing space)

* Adding C# version history post (#2867)

* Create csharp-version-history.md

* Added the actual text

* Updated TOC with my entry.

* first pass edit

1. Add Metadata
1. Change person
1. Formalize from blog post to docs style language.

* Update csharp-version-history.md

* fix build warnings on links.

* respond to feedback

* fixed build warnings

* fixed version capitalization
OPSTestPPE referenced this pull request in OPS-E2E-PPE/docs Sep 22, 2017
* fixed broken link (#3169)

* fixed pipes in tables (#3163)

* added info about relative paths for output (#3042)

* added info about relative paths for output

* edits

* Update how-to-write-a-simple-parallel-for-loop.md (#3174)

Updated Cut to Copy in Copy/Cut and Paste this code into ...

* fixed formulas (#3182)

* fixed formulas

* fixed formula

* fixed formula

* simplifying version list (#3176)

* Minor fixes : inconsistent wording and some ghost characters (#3171)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* minor typos

* compiler warning corrected to match previously mentioned number
* removed a "ghost" quote

* fixed inconsistent "read-only" and "read only"

* code formatting (missing space)

* Adding C# version history post (#2867)

* Create csharp-version-history.md

* Added the actual text

* Updated TOC with my entry.

* first pass edit

1. Add Metadata
1. Change person
1. Formalize from blog post to docs style language.

* Update csharp-version-history.md

* fix build warnings on links.

* respond to feedback

* fixed build warnings

* fixed version capitalization

* Learn C# Tutorial (#2306)

* First draft of new tutorial

Learn the structure of a C# program, and  explore the string class.

proofread and tighten language.

respond to feedback

2nd draft

Move more code earlier.
Tighten vocabulary discussions.

Update outline

start on the next draft.

add section on searching strings

fix build errors

finish the string tutorial.

reorder: ready for proofread.

proofread

update to use new syntax

Update Tutorial to use the new engine

typo in the title

* build test, try samples

* 2nd draft of the numbers tutorial.

* proofread the second tutorial and create the third

Branching and looping is ready for initial review.

* respond to feedback on first tutorial.

* proof read 3rd tutorial

And add links to other C# Guide content

* Remove links to upcoming tutorials.

* Respond to feedback.

* fix yaml parsing error.

* More feedback.

* feedback from team review

Configure ms.technology for all quick starts to be
devlang-csharp-interactive.
Update .NET home page and C# Guide home page to point to the
interactive tutorials.

* Describe booleans, and update metadata.

* add a tip about compiler messages

* update timings of tutorials, update tip text

* final review.

* Fix typo: AesCrytpServiceProvider -> AesCryptoServiceProvider (#3185)

* Fix typo: AesCrytpServiceProvider -> AesCryptoServiceProvider

* Fix typo: crytopgraphy -> cryptography

* added net core behavior (#3140)

* added net core behavior

* feedback

* feedback

* feedback

* quick link fix to the hub page (#3193)

The link target was updated for the Quick Starts, but the displayed
text was not.

* Removed duplicate entry from 'See Also' section (#3195)

* removed invisible characters (#3192)

* update snippet reference (#3191)

* fixed broken link (#3190)

* clarified example (#3184)

* Updating condition(s) under which the method throws (#3152)

* Updating condition(s) under which the method throws

* Correcting a few hard-to-localize bits of content

* Update mutually recursive functions snippet (#3186)

* Update mutually recursive functions snippet

Correct implementation should be something like (this one)[https://en.wikipedia.org/wiki/Mutual_recursion]

* Typo fix in function name

Event -> Even

* 494407 Corrections to DnsSafeHost and IdnHost (#3143)

* 494407 Corrections to DnsSafeHost and IdnHost

* Actioning all comments :)

* I used the wrong inline code delimiter

* Improve Suits and Ranks definitions (#3197)

* update target framework to 2.0

* Improve Suits and Ranks enumerable definitions

* Revert "update target framework to 2.0"

This reverts commit 008d19d.

* Fixed Kelvin output, make culture independent (#3157)

* Fixed Kelvin output, make culture independent

- Fixed wrong expected output for Kelvin in the sample usage
- Defined current culture in the sample usage to work out-of-the-box for international locales

* Remove obsolete full qualified name

* CurrentThread.CurrentCulture -> CultureInfo.CurrentCulture

* Fixed Kelvin output, make culture independent (#3159)

* Fixed Kelvin output, make culture independent

- Fixed wrong expected output for Kelvin in the sample usage
- Defined current culture in the sample usage to work out-of-the-box for international locales

* Remove obsolete full qualified name

* CurrentThread.CurrentCulture -> CultureInfo.CurrentCulture

* Remove Duplicate Config Definition (#3200)

For whatever reason, the sample XML was duplicated -- this commit removes that duplication so that the example is more readable.

* fixed api link format (#3194)

* Typo in document - IOne instead of One (#3202)

Typo in document - IOne instead of One

* Fix framework in dotnet store command topic (#3188)

Reported by @pauliusnorkus. Thanks to @dasMulli for reminding me about the framework problem here. Using `netstandard2.0` worked during pre-release but no more.
OPSTestPPE referenced this pull request in OPS-E2E-PPE/docs Sep 22, 2017
* fixed broken link (#3169)

* fixed pipes in tables (#3163)

* added info about relative paths for output (#3042)

* added info about relative paths for output

* edits

* Update how-to-write-a-simple-parallel-for-loop.md (#3174)

Updated Cut to Copy in Copy/Cut and Paste this code into ...

* fixed formulas (#3182)

* fixed formulas

* fixed formula

* fixed formula

* simplifying version list (#3176)

* Minor fixes : inconsistent wording and some ghost characters (#3171)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* minor typos

* compiler warning corrected to match previously mentioned number
* removed a "ghost" quote

* fixed inconsistent "read-only" and "read only"

* code formatting (missing space)

* Adding C# version history post (#2867)

* Create csharp-version-history.md

* Added the actual text

* Updated TOC with my entry.

* first pass edit

1. Add Metadata
1. Change person
1. Formalize from blog post to docs style language.

* Update csharp-version-history.md

* fix build warnings on links.

* respond to feedback

* fixed build warnings

* fixed version capitalization

* Learn C# Tutorial (#2306)

* First draft of new tutorial

Learn the structure of a C# program, and  explore the string class.

proofread and tighten language.

respond to feedback

2nd draft

Move more code earlier.
Tighten vocabulary discussions.

Update outline

start on the next draft.

add section on searching strings

fix build errors

finish the string tutorial.

reorder: ready for proofread.

proofread

update to use new syntax

Update Tutorial to use the new engine

typo in the title

* build test, try samples

* 2nd draft of the numbers tutorial.

* proofread the second tutorial and create the third

Branching and looping is ready for initial review.

* respond to feedback on first tutorial.

* proof read 3rd tutorial

And add links to other C# Guide content

* Remove links to upcoming tutorials.

* Respond to feedback.

* fix yaml parsing error.

* More feedback.

* feedback from team review

Configure ms.technology for all quick starts to be
devlang-csharp-interactive.
Update .NET home page and C# Guide home page to point to the
interactive tutorials.

* Describe booleans, and update metadata.

* add a tip about compiler messages

* update timings of tutorials, update tip text

* final review.

* Fix typo: AesCrytpServiceProvider -> AesCryptoServiceProvider (#3185)

* Fix typo: AesCrytpServiceProvider -> AesCryptoServiceProvider

* Fix typo: crytopgraphy -> cryptography

* added net core behavior (#3140)

* added net core behavior

* feedback

* feedback

* feedback

* quick link fix to the hub page (#3193)

The link target was updated for the Quick Starts, but the displayed
text was not.

* Removed duplicate entry from 'See Also' section (#3195)

* removed invisible characters (#3192)

* update snippet reference (#3191)

* fixed broken link (#3190)

* clarified example (#3184)

* Updating condition(s) under which the method throws (#3152)

* Updating condition(s) under which the method throws

* Correcting a few hard-to-localize bits of content

* Update mutually recursive functions snippet (#3186)

* Update mutually recursive functions snippet

Correct implementation should be something like (this one)[https://en.wikipedia.org/wiki/Mutual_recursion]

* Typo fix in function name

Event -> Even

* 494407 Corrections to DnsSafeHost and IdnHost (#3143)

* 494407 Corrections to DnsSafeHost and IdnHost

* Actioning all comments :)

* I used the wrong inline code delimiter

* Improve Suits and Ranks definitions (#3197)

* update target framework to 2.0

* Improve Suits and Ranks enumerable definitions

* Revert "update target framework to 2.0"

This reverts commit 008d19d.

* Fixed Kelvin output, make culture independent (#3157)

* Fixed Kelvin output, make culture independent

- Fixed wrong expected output for Kelvin in the sample usage
- Defined current culture in the sample usage to work out-of-the-box for international locales

* Remove obsolete full qualified name

* CurrentThread.CurrentCulture -> CultureInfo.CurrentCulture

* Fixed Kelvin output, make culture independent (#3159)

* Fixed Kelvin output, make culture independent

- Fixed wrong expected output for Kelvin in the sample usage
- Defined current culture in the sample usage to work out-of-the-box for international locales

* Remove obsolete full qualified name

* CurrentThread.CurrentCulture -> CultureInfo.CurrentCulture

* Remove Duplicate Config Definition (#3200)

For whatever reason, the sample XML was duplicated -- this commit removes that duplication so that the example is more readable.

* fixed api link format (#3194)

* Typo in document - IOne instead of One (#3202)

Typo in document - IOne instead of One

* Fix framework in dotnet store command topic (#3188)

Reported by @pauliusnorkus. Thanks to @dasMulli for reminding me about the framework problem here. Using `netstandard2.0` worked during pre-release but no more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants