Skip to content

Add binder breaking change - #26031

Merged
gewarren merged 3 commits into
dotnet:mainfrom
gewarren:array
Sep 20, 2021
Merged

Add binder breaking change#26031
gewarren merged 3 commits into
dotnet:mainfrom
gewarren:array

Conversation

@gewarren

@gewarren gewarren commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

@dotnet-bot dotnet-bot added this to the September 2021 milestone Sep 9, 2021
@gewarren
gewarren requested review from a team, maryamariyan and safern September 9, 2021 21:58
}
```

The JSON configuration provider would not bind that JSON because it does not specify an array. The JSON would need to appear as follows in order to bind:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I explained this correctly. Please correct if necessary. I'm trying to show what's change for the JSON provider.

@gewarren gewarren closed this Sep 10, 2021
@gewarren gewarren reopened this Sep 10, 2021
@BillWagner

Copy link
Copy Markdown
Member

closing and reopening for a fresh build

@BillWagner BillWagner closed this Sep 10, 2021
@BillWagner BillWagner reopened this Sep 10, 2021

@safern safern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gewarren
gewarren merged commit 200a5f7 into dotnet:main Sep 20, 2021
@gewarren
gewarren deleted the array branch September 20, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breaking change]: Microsoft.Extensions.Configuration binder will now bind single elements to an array

4 participants