Skip to content

Update code-generation.md with debugtype values - #23509

Merged
adegeo merged 2 commits into
mainfrom
adegeo-patch-1
Mar 29, 2021
Merged

adegeo merged 2 commits into
mainfrom
adegeo-patch-1

Conversation

@adegeo

@adegeo adegeo commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

@adegeo
adegeo requested a review from BillWagner March 26, 2021 17:45
@dotnet-bot dotnet-bot added this to the March 2021 milestone Mar 26, 2021
@adegeo adegeo changed the title Update code-generation.md Update code-generation.md with debugtype values Mar 26, 2021

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @adegeo

You can :shipit: when ready.

@adegeo
adegeo merged commit 16ac808 into main Mar 29, 2021
@adegeo
adegeo deleted the adegeo-patch-1 branch March 29, 2021 16:35
@ericsampson

ericsampson commented Mar 29, 2021 •

Copy link
Copy Markdown

@BillWagner/@adegeo, does this note section (being only applicable to the older compilers) imply that portable/embedded has zero impact on performance (JITing etc) and so is fine to leave on in release mode?
Or should there be a new section discussing that, not under an "only applicable for old compilers" heading...

Also, the mention that "pdbonly - Same as full" is somewhat misleading/confusing, when the section that it references directly below describes significant differences between them...
It seems like it would be a lot clearer to say something like:

| pdbonly | For backward compatibility; same as full for C# compiler version > 6.0. For C# compilers <= 6.0, see the note below for more information. |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review/update documentation of the 'debug' C# compiler option

4 participants