Skip to content

[DO NOT MERGE] removing articles from URL - #2012

Merged
mairaw merged 4 commits into
dotnet:change-urlfrom
mairaw:seo-articles
May 3, 2017
Merged

mairaw merged 4 commits into
dotnet:change-urlfrom
mairaw:seo-articles

Conversation

@mairaw

@mairaw mairaw commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

Need to test if the configuration I've applied on docfx.json was done correctly.

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good.
I'm wondering if there is a way in the global redirection file to catch any links from outside the site that contain 'articles' and route them correctly? If not, where do they go?

If we have time, it would be better to use the relative links inside our own docset. Would you agree?

================

This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/articles/core/tutorials/using-with-xplat-cli)
This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/core/tutorials/using-with-xplat-cli)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't these be more resilient if we targeted the markdown using a relative link?
e g: ../../tutorials/using-with-xplat-cli.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner these are supposed to be the readme files for the samples. they are not published so if you're looking at this file on your machine, you need the absolute URL.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw I need to get my eyes checked. I thought they were in the main doc set. Not sure what I was seeing...

================

This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/articles/core/tutorials/using-with-xplat-cli)
This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/core/tutorials/using-with-xplat-cli)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

================

This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/articles/core/tutorials/using-with-xplat-cli)
This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/core/tutorials/using-with-xplat-cli)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

================

This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/articles/core/tutorials/using-with-xplat-cli)
This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/core/tutorials/using-with-xplat-cli)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

================

This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/articles/core/tutorials/using-with-xplat-cli)
This sample is part of the [step-by-step tutorial](https://docs.microsoft.com/dotnet/core/tutorials/using-with-xplat-cli)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

================

This sample is created during the [Versioning](https://docs.microsoft.com/dotnet/articles/csharp/versioning)
This sample is created during the [Versioning](https://docs.microsoft.com/dotnet/csharp/versioning)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

# .NET Core Library Samples

These samples are buildable projects whose source is used for code snippets in [the guide for writing cross-platform libraries](https://docs.microsoft.com/dotnet/articles/core/tutorials/libraries). They can be built and run using the .NET Core toolchain, and are intended to simply demonstrate how to target and build NuGet packages for different targets. They aren't examples of how you'd build a real, feature-complete library.
These samples are buildable projects whose source is used for code snippets in [the guide for writing cross-platform libraries](https://docs.microsoft.com/dotnet/core/tutorials/libraries). They can be built and run using the .NET Core toolchain, and are intended to simply demonstrate how to target and build NuGet packages for different targets. They aren't examples of how you'd build a real, feature-complete library.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

* Mono

It uses the `netstandard1.2` Target Framework Moniker introduced with the [.NET Standard Library](https://docs.microsoft.com/en-us/dotnet/articles/standard/library).
It uses the `netstandard1.2` Target Framework Moniker introduced with the [.NET Standard Library](https://docs.microsoft.com/en-us/dotnet/standard/library).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

**IMPORTANT:** This project requires Windows and the the .NET Framework installed on your machine.

The project under `/net40-library` targets the .NET Framework 4.0 and above. It also demonstrates how to use [#if](https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/preprocessor-directives/preprocessor-if) directives to multi-target for a .NET 4.0 target.
The project under `/net40-library` targets the .NET Framework 4.0 and above. It also demonstrates how to use [#if](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives/preprocessor-if) directives to multi-target for a .NET 4.0 target.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

**IMPORTANT:** This project requires Windows and the .NET Framework installed on your machine.

The project under `/pcl-library` shows how to target a supported PCL Profile (for example, 344). It shows how to structure the `Library.csproj` file to allow for targeting a PCL. It also demonstrates how to use [#if](https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/preprocessor-directives/preprocessor-if) directives and how to define a preprocessor constant, `PORTABLE259` in the `Library.csproj` file.
The project under `/pcl-library` shows how to target a supported PCL Profile (for example, 344). It shows how to structure the `Library.csproj` file to allow for targeting a PCL. It also demonstrates how to use [#if](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives/preprocessor-if) directives and how to define a preprocessor constant, `PORTABLE259` in the `Library.csproj` file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative link?

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also.

@mairaw mairaw added the WIP label Apr 25, 2017
@mairaw

mairaw commented Apr 25, 2017 •

Copy link
Copy Markdown
Contributor Author

If I understand the redirection process correctly, any links to https://docs.microsoft.com/en-us/dotnet/articles/* would go to https://docs.microsoft.com/en-us/dotnet/*. This is the part that will be done via Akamai.

We do use relative urls in our repo. The ones I'm fixing were done like this because they are for the readme files. But they would continue to work. I'm just avoiding the redirection by fixing them.

@mairaw

mairaw commented Apr 25, 2017 •

Copy link
Copy Markdown
Contributor Author

URLs don't have articles any longer on staging but there are some oddities I'm seeing on the TOC. I'll need to investigate why that's happening.

image

@mairaw
mairaw changed the base branch from master to change-url May 3, 2017 07:15
@mairaw

mairaw commented May 3, 2017

Copy link
Copy Markdown
Contributor Author

The changes need to be in a branch for the build to fully work (engineering team opened a bug). So merging this one now and opening a new PR to merge against master to test this change.

@mairaw
mairaw merged commit 8f56bdd into dotnet:change-url May 3, 2017
@mairaw
mairaw deleted the seo-articles branch May 3, 2017 08:14
mairaw added a commit that referenced this pull request May 25, 2017
* removing articles from url (#2012)

* removed extra articles

* updated redirect

* removed all articles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants