Skip to content

26). Add topic files 75 to 78 - #18050

Merged
BillWagner merged 10 commits into
dotnet:linq-to-xmlfrom
jameshkramer:br26-add-topic-files-75-to-78
May 5, 2020
Merged

BillWagner merged 10 commits into
dotnet:linq-to-xmlfrom
jameshkramer:br26-add-topic-files-75-to-78

Conversation

@jameshkramer

Copy link
Copy Markdown
Contributor

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. There are also fixes to toc.yml and to several article files.

Please merge #17846, #17892, #17928., and #18022 before merging this.

cc: @BillWagner @mairaw @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 23, 2020
@jameshkramer
jameshkramer force-pushed the br26-add-topic-files-75-to-78 branch from e43768a to 5be46a8 Compare April 24, 2020 16:49
@jameshkramer
jameshkramer deleted the br26-add-topic-files-75-to-78 branch April 24, 2020 17:13
@jameshkramer
jameshkramer restored the br26-add-topic-files-75-to-78 branch April 24, 2020 17:26
@jameshkramer jameshkramer reopened this Apr 24, 2020
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Apr 26, 2020

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments for you to consider.

Comment thread docs/standard/linq/toc.yml Resolved
@Thraka
Thraka removed the request for review from a team May 1, 2020 17:19

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some minor comments to be addressed before merging.

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@BillWagner

Copy link
Copy Markdown
Member

Based on @mairaw's review and subsequent updates, I'll :shipit: now.

@BillWagner
BillWagner merged commit 03e9ccb into dotnet:linq-to-xml May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vendor-project Indicates the issue/pr is related to a vendor project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants