Skip to content

Fixed "[+|-]"→"[+\|-]" - #16526

Merged
mairaw merged 4 commits into
dotnet:masterfrom
hyoshioka0128:patch-13
Jan 14, 2020
Merged

mairaw merged 4 commits into
dotnet:masterfrom
hyoshioka0128:patch-13

Conversation

@hyoshioka0128

Copy link
Copy Markdown
Contributor

@Youssef1313 Youssef1313 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it must be escaped.

@hyoshioka0128 hyoshioka0128 changed the title Fixed "[+|-]"→"[+|-]" Fixed "[+|-]"→"[+\|-]" Jan 4, 2020

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hyoshioka0128 for the bug fix but that didn't quite work. I left a suggestion on how I think we can make that work instead.

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied the feedback so we can merge this PR if build looks good. We're starting to get customer feedback on this issue, so I'd like to merge this sooner rather than later.

@mairaw
mairaw merged commit c044adb into dotnet:master Jan 14, 2020
hyoshioka0128 added a commit to hyoshioka0128/docs.ja-jp that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants