Skip to content

Update unit-testing-with-dotnet-test.md - #15954

Merged
Rick-Anderson merged 9 commits into
masterfrom
Rick-Anderson-patch-1
Dec 4, 2019
Merged

Rick-Anderson merged 9 commits into
masterfrom
Rick-Anderson-patch-1

Conversation

@Rick-Anderson

@Rick-Anderson Rick-Anderson commented Nov 22, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #15752
Fixes #9785
Fixes #9244 <- doesn't really fix that issue, but issue is not valid and should be closed.

Internal review URL

@Rick-Anderson
Rick-Anderson marked this pull request as ready for review November 23, 2019 01:45
@Rick-Anderson
Rick-Anderson requested review from Thraka and removed request for mairaw November 23, 2019 01:45
Rick-Anderson and others added 3 commits November 22, 2019 18:14
Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@Rick-Anderson

Copy link
Copy Markdown
Contributor Author

@Youssef1313 thanks for the suggestions. I can post a public view of the build if you'd like.

@mairaw

mairaw commented Nov 23, 2019

Copy link
Copy Markdown
Contributor

I think this is one of the topics has copies in VB and F#. There are plans to put them in one but still on the backlog.

@Rick-Anderson

Copy link
Copy Markdown
Contributor Author

@Thraka can you review. I need this to merge so I can finish my CSAT/OKR?

@Thraka Thraka left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. One minor improvement suggestion. Also, you should update the date on the article since this is a major rewrite

Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
@Rick-Anderson
Rick-Anderson merged commit 9113a5d into master Dec 4, 2019
@Rick-Anderson
Rick-Anderson deleted the Rick-Anderson-patch-1 branch December 4, 2019 03:13
```

Continue to iterate by adding more tests, more theories, and more code in the main library. You have the [finished version of the tests](https://github.com/dotnet/samples/blob/master/core/getting-started/unit-testing-using-dotnet-test/PrimeService.Tests/PrimeService_IsPrimeShould.cs) and the [complete implementation of the library](https://github.com/dotnet/samples/blob/master/core/getting-started/unit-testing-using-dotnet-test/PrimeService/PrimeService.cs).
Following the TDD approach, add more failing test, then update the target code. See the [finished version of the tests](https://github.com/dotnet/samples/blob/master/core/getting-started/unit-testing-using-dotnet-test/PrimeService.Tests/PrimeService_IsPrimeShould.cs) and the [complete implementation of the library](https://github.com/dotnet/samples/blob/master/core/getting-started/unit-testing-using-dotnet-test/PrimeService/PrimeService.cs).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"add more failing tests"
(missing 's')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardalis, opened #16093

mairaw added a commit that referenced this pull request Dec 4, 2019
* updating links from fwlink to real link if exists (#15945)

* updating links from fwlink to real link if exists

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* undoing linking change

* Update docs/framework/whats-new/obsolete-types.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* updating aspnet links

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content (#14590)

* [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content

* additional changes

* Updates for the new dotnet/runtime repo (#15983)

* Update system-text-json-overview.md

* Update system-text-json-overview.md

* Update system-text-json-overview.md

* Update about.md

* Update instructions for RHEL (#16050)

* Update instructions for RHEL

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Update date

* Fixes #11069 (#16058)

* Fix typo in timespan format (#16071)

* Replace Windows 7/8 tokens (#16074)

* Replace Windows 7 tokens

* Remove win7-md.md

* Replace Windows 8 tokens

* Remove win8-md.md

* Replace Windows 8.1 tokens

* Remove win81-md.md

* add later versions (#16076)

* add later versions

* Apply suggestions from docs review

Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>

* remove version from link text (#16077)

* Spark: spark streaming article (#15842)

* spark streaming article

* make spark streaming a tutorial

* Update docs/spark/tutorials/streaming.md

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* update link

* Update docs/spark/tutorials/streaming.md

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>

* update xrefs

* fix xref

* Update unit-testing-with-dotnet-test.md (#15954)

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Apply suggestions from code review

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update docs/core/testing/unit-testing-with-dotnet-test.md

Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>

* Run-time config knobs (#16019)

* add settings to toc

* add config files for various settings

* add working with calendars changes

* updating links from fwlink to real link if exists (#16065)

* updating links from fwlink to real link if exists - contributes to #3391

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* undoing samples fwlink

* Update docs/framework/windows-workflow-foundation/how-to-host-multiple-versions-of-a-workflow-side-by-side.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* add a later version (#16080)

* add a later version

* more updates

* Update docs/framework/debug-trace-profile/pinvokestackimbalance-mda.md

Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>

* fix backtick escaping (#16056)

* separate OS info (#16063)

* Typo, add missing "s" (#16093)
@mairaw

mairaw commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

Why was this part of your OKRs since it's our content and why the other language counterparts were not updated with this? Now they're out of sync.

@Rick-Anderson

Copy link
Copy Markdown
Contributor Author

@mairaw my OKR is Unit test controller logic in ASP.NET Core. The rewrite of that depends on this. I couldn't point to this tutorial, it was too poorly written and too much work to follow.

why the other language counterparts were not updated with this? Now they're out of sync.

See the related issues I created. Per Satya, We focus on items that have meaningful results.
They're not out of sync. Hopefully we'll get a volunteer to update them.

image

BillWagner added a commit that referenced this pull request Jun 15, 2020
* #15390 Remove links to outdated tutorials on string interpolation (#15401)

* Update live with current master (#16095)

* updating links from fwlink to real link if exists (#15945)

* updating links from fwlink to real link if exists

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* undoing linking change

* Update docs/framework/whats-new/obsolete-types.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* updating aspnet links

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content (#14590)

* [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content

* additional changes

* Updates for the new dotnet/runtime repo (#15983)

* Update system-text-json-overview.md

* Update system-text-json-overview.md

* Update system-text-json-overview.md

* Update about.md

* Update instructions for RHEL (#16050)

* Update instructions for RHEL

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Update date

* Fixes #11069 (#16058)

* Fix typo in timespan format (#16071)

* Replace Windows 7/8 tokens (#16074)

* Replace Windows 7 tokens

* Remove win7-md.md

* Replace Windows 8 tokens

* Remove win8-md.md

* Replace Windows 8.1 tokens

* Remove win81-md.md

* add later versions (#16076)

* add later versions

* Apply suggestions from docs review

Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>

* remove version from link text (#16077)

* Spark: spark streaming article (#15842)

* spark streaming article

* make spark streaming a tutorial

* Update docs/spark/tutorials/streaming.md

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* update link

* Update docs/spark/tutorials/streaming.md

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>

* update xrefs

* fix xref

* Update unit-testing-with-dotnet-test.md (#15954)

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Apply suggestions from code review

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* Update unit-testing-with-dotnet-test.md

* Update unit-testing-with-dotnet-test.md

* Update docs/core/testing/unit-testing-with-dotnet-test.md

Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>

* Run-time config knobs (#16019)

* add settings to toc

* add config files for various settings

* add working with calendars changes

* updating links from fwlink to real link if exists (#16065)

* updating links from fwlink to real link if exists - contributes to #3391

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* undoing samples fwlink

* Update docs/framework/windows-workflow-foundation/how-to-host-multiple-versions-of-a-workflow-side-by-side.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* add a later version (#16080)

* add a later version

* more updates

* Update docs/framework/debug-trace-profile/pinvokestackimbalance-mda.md

Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>

* fix backtick escaping (#16056)

* separate OS info (#16063)

* Typo, add missing "s" (#16093)

* update live with master (#17118)

* fix last msdn blogs urls (#17089)

* fix last msdn blogs urls

* Remove locale

* Remove period

* Microservices guide general update to 3.1 (#16202)

* Update authentication

* Update Visual Studio 2017 references and images

* Update references and some code snippets to 3.1

* Update references + code snippets to 3.1

* Update IHostedServices Section

* Update value objects section

* Apply suggestions from code review

Co-Authored-By: Nish Anil <nish@microsoft.com>

* Apply suggestions from code review

Co-Authored-By: Nish Anil <nish@microsoft.com>

* Apply further review comments

* Fix Markdownlinter errors

* Apply suggestions from code review

Missed review comment

Co-Authored-By: Nish Anil <nish@microsoft.com>

* Fix image name

* Update edit dates

* Remove remnant temporary file

* Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md

* Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md

* Replaced Important with Note

* Update implement-api-gateways-with-ocelot.md

* Fix blank lines

* Update position

* Apply suggestions from code review (to be continued...)

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Apply suggestions from code review

Ready with suggestions, manual changes are coming next.

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Apply manual changes from reviews.

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Add more review comments

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Remove locale from link

* Update docs/architecture/microservices/implement-resilient-applications/monitor-app-health.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Add review comments

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Add review comment from local repo.

Co-authored-by: Nish Anil <nish@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>

* Update Azure table offerings for application Architecture (#17011)

* Update table
- Update recommendations
- Convert it to markdown for accessibility

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Apply review comments.

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>

* Document warnaserror:nullable option (#17094)

* Modulo operator -> remainder operator (#17102)

* update some CLI ref commands for 3.1 (#17101)

* update CLI ref commands for 3.1

* fix

* Add link to tutorial of using pattern matching (#17108)

* Remove the note about the struct breaking change from the conceptual docs (#17114)

* Fix the note about the struct breaking change

* Removed the note

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Miguel Veloso <mvelosop@gmail.com>
Co-authored-by: Nish Anil <nish@microsoft.com>
Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com>
Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com>
Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com>

* Add f1_keywords to keyword-reference (#17624)

These keywords are listed in archived F# keywords topic (https://docs-archive.visualstudio.com/docs-archive-project/_git/VS2013-docs-archive-pr?path=%2Fvs-2013%2Fdd233249(v%3Dvs.120).md&amp%3Bversion=GBlive&amp%3B_a=contents). Docs.F1 needs these keywords added in the fresh content to return a fresh result for those F1 keywords.

* Revert "Install for Ubuntu 20.04 (#17869)" (#18089) (#18092)

This reverts commit 7eb84cf.

* Fix default checksum algorithm

Fixes #18925

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Ron Petrusha <ronpet@microsoft.com>
Co-authored-by: Pablo Marcano <pablo1012@outlook.com>
Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com>
Co-authored-by: Genevieve Warren <gewarren@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Miguel Veloso <mvelosop@gmail.com>
Co-authored-by: Nish Anil <nish@microsoft.com>
Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com>
Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com>
Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com>
Co-authored-by: Nat Kershaw (MSFT) <nakersha@microsoft.com>
Co-authored-by: CXWTool Service Account <cxwtool@microsoft.com>
Co-authored-by: junshi356 <40595015+junshi356@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants