Skip to content

fix: Markdownlint - #14388

Merged
mairaw merged 15 commits into
dotnet:masterfrom
nschonni:fix--Markdownlint
Sep 14, 2019
Merged

mairaw merged 15 commits into
dotnet:masterfrom
nschonni:fix--Markdownlint

Conversation

@nschonni

Copy link
Copy Markdown
Contributor

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you mind applying the suggestions I called out?

@nschonni

Copy link
Copy Markdown
Contributor Author

Rebased for a few stray MD032 issues after the other PR landed

@nschonni

Copy link
Copy Markdown
Contributor Author

Rebased and addressed the new ones.
There was also a merge conflict and an unclosed tab section that the build flagged

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the additional changes @nschonni. Left two additional comments.

nschonni and others added 12 commits September 13, 2019 19:56
- MD047/single-trailing-newline
- MD030/list-marker-space
- trim trailing/leading space
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
…reak-and-combine-statements-in-code.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Multiple top level headings in the same document
Multiple consecutive blank lines
Files should end with a single newline character
Ordered list item prefix
nschonni and others added 3 commits September 13, 2019 20:07
Fenced code blocks should be surrounded by blank lines
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw
mairaw merged commit 41483d9 into dotnet:master Sep 14, 2019
@nschonni
nschonni deleted the fix--Markdownlint branch September 14, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants