Skip to content

Update link from obsolete to current event - #14081

Merged
rpetrusha merged 3 commits into
dotnet:masterfrom
ite-jankl:patch-1
Aug 30, 2019
Merged

rpetrusha merged 3 commits into
dotnet:masterfrom
ite-jankl:patch-1

Conversation

@ite-jankl

@ite-jankl ite-jankl commented Aug 29, 2019 •

Copy link
Copy Markdown
Contributor

The Form.Closing event is obsolete since .NET Framework version 2.0 as
per its documentation.
It has been replaced by the Form.FormClosing event, which we now link to
instead.

The Form.Closing event is obsolete since .NET Framework version 2.0 as
per its documentation.
It has been replaced by the Form.FormClosing event, which we now link to
instead.
@ite-jankl
ite-jankl requested a review from Thraka as a code owner August 29, 2019 07:34
@Youssef1313

Copy link
Copy Markdown
Member

There is another occurrence in the same paragraph you edited, and also in the See Also section.

@ite-jankl

Copy link
Copy Markdown
Contributor Author

@Youssef1313 good catch. fixed 👍

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Aug 29, 2019
@rpetrusha rpetrusha added this to the August 2019 milestone Aug 29, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ite-klass, for contributing to the dotnet/docs repo and updating the documentation. I thought that one of the cross-references should also be updated to mention the FormClosingEventArgs class.

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@rpetrusha

Copy link
Copy Markdown
Contributor

Thanks, @ite-klass, for making the additional change. I'll merge your PR now. Your changes should be live on docs.microsoft.com in the next day or two.

@rpetrusha
rpetrusha merged commit b1f8cfd into dotnet:master Aug 30, 2019
@ite-jankl

Copy link
Copy Markdown
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants