Skip to content

[framework] Remove redundant path segments (part 1) - #13928

Merged
mairaw merged 51 commits into
dotnet:masterfrom
nemrism:redundant-path-framework-1
Sep 16, 2019
Merged

mairaw merged 51 commits into
dotnet:masterfrom
nemrism:redundant-path-framework-1

Conversation

@nemrism

@nemrism nemrism commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

Remove redundant path in relative links inside /framework/** files

Contributes to #10653

@nemrism
nemrism requested review from karelz and mairaw as code owners August 19, 2019 22:49
@mairaw

mairaw commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

I know these changes are super straightforward but let's try to keep these PRs with ~100 files. I'll review this one as-is though.

@mairaw mairaw added this to the August 2019 milestone Aug 20, 2019
Comment thread docs/framework/additional-apis/index.md Resolved

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful to see these changes. In addition to the broken link I've pointed out, I also have a few additional comments. I've reviewed 200/502 files so far.

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments... 300/502 files reviewed.

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments,,, 400/502

Comment thread docs/framework/resources/index.md Resolved

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the review now. A couple more comments...

Also, apologies for including two commits here that were supposed to be done on a separate PR I'm working on. It's fine to leave them here if they don't cause any issues.

@nemrism

nemrism commented Aug 20, 2019 •

Copy link
Copy Markdown
Contributor Author

@mairaw :

I applied all suggested fixes about "incorrect" includes of media files

I've changed all links to /standard section in the following PR: #13925 as this replacement work is quite huge even if I split by folders...
Once it will be merged I could rebase this branch in order to "facilitate" the final review.

@mairaw

mairaw commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

@nemrism can you fix the merge conflicts?

@nemrism

nemrism commented Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

Yes, I'll push that asap

@nemrism nemrism changed the title [framework] Remove redundant path segments (part 1) [WIP][framework] Remove redundant path segments (part 1) Aug 21, 2019
@nemrism nemrism changed the title [WIP][framework] Remove redundant path segments (part 1) [framework] Remove redundant path segments (part 1) Aug 21, 2019
@nemrism

nemrism commented Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

Merged, resolved and ready for your review @mairaw

@mairaw

mairaw commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

Thanks @nemrism. @rpetrusha I'm afraid this will cause new merge conflicts for #13851. Should we hold off until that one is merged?

@mairaw mairaw added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Aug 22, 2019
@nemrism

nemrism commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

cc @mairaw / @rpetrusha

Just tested the v-thepet/move2 branch against this one. It is indeed the most impacted one by merge conflicts but it is quite easy to resolve them.

Let me know when the #13851 PR will be merged, I'll handle the conflicts.

I'll continue to work on the #10653 resolution, it seems that other section are less impacted, automatic merge works fine on most of other related PR.

@mairaw

mairaw commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

That PR was now merged. Can you please rebase your PR? Thanks!

@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Sep 13, 2019
@nemrism

nemrism commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Yes of course!
I'll prepare that and tell you when this one is ready for final review.

@nemrism nemrism changed the title [framework] Remove redundant path segments (part 1) [WiP][framework] Remove redundant path segments (part 1) Sep 14, 2019
@nemrism nemrism changed the title [WiP][framework] Remove redundant path segments (part 1) [framework] Remove redundant path segments (part 1) Sep 16, 2019
@nemrism

nemrism commented Sep 16, 2019

Copy link
Copy Markdown
Contributor Author

All done, ready for final review @mairaw

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thank you @nemrism!

@mairaw
mairaw merged commit ec37d64 into dotnet:master Sep 16, 2019
@nemrism
nemrism deleted the redundant-path-framework-1 branch September 17, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants