Repository navigation
[framework] Remove redundant path segments (part 1) - #13928
Conversation
|
I know these changes are super straightforward but let's try to keep these PRs with ~100 files. I'll review this one as-is though. |
mairaw
left a comment
There was a problem hiding this comment.
Wonderful to see these changes. In addition to the broken link I've pointed out, I also have a few additional comments. I've reviewed 200/502 files so far.
mairaw
left a comment
There was a problem hiding this comment.
A few more comments... 300/502 files reviewed.
mairaw
left a comment
There was a problem hiding this comment.
Finished the review now. A couple more comments...
Also, apologies for including two commits here that were supposed to be done on a separate PR I'm working on. It's fine to leave them here if they don't cause any issues.
|
@mairaw : I applied all suggested fixes about "incorrect" includes of I've changed all links to |
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
…-overview.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@nemrism can you fix the merge conflicts? |
|
Yes, I'll push that asap |
|
Merged, resolved and ready for your review @mairaw |
|
Thanks @nemrism. @rpetrusha I'm afraid this will cause new merge conflicts for #13851. Should we hold off until that one is merged? |
|
cc @mairaw / @rpetrusha Just tested the v-thepet/move2 branch against this one. It is indeed the most impacted one by merge conflicts but it is quite easy to resolve them. Let me know when the #13851 PR will be merged, I'll handle the conflicts. I'll continue to work on the #10653 resolution, it seems that other section are less impacted, automatic merge works fine on most of other related PR. |
|
That PR was now merged. Can you please rebase your PR? Thanks! |
|
Yes of course! |
|
All done, ready for final review @mairaw |
Remove redundant path in relative links inside /framework/** files
Contributes to #10653