Skip to content

Page display does not match its source #4674

Closed

Description

@pkulikov

The page about in keyword shows content that differs from the corresponding Markdown file.

What I see:
image

What I see after clicking Edit link on that page:
image

The same observation is valid for the C# keywords page (check for in links). And for the async keyword page as well. That looks it might be the case for the files updated in PR #4534

cc: @BillWagner

Activity

  1. BillWagner commented on Mar 15, 2018

    @BillWagner
    Member

    Thanks for pointing this out. I'll look at the most recent builds and see what happened.

    We publish from the 'live' branch, but we work on the 'master' branch. I'll figure out why those changes didn't make it to the most recent publish.

  2. BillWagner commented on Mar 15, 2018

    @BillWagner
    Member

    It was a publish / build that failed due to a resource allocation problem. I've started a new build. I will validate this once the build finishes and we get a new build published.

  3. BillWagner commented on Mar 15, 2018

    @BillWagner
    Member

    @pkulikov If you are looking to modify this page, you may want to wait. I'm in the process of updating it for the 7.2 tie breaker change for in and by value parameters. I'll open the PR later today, and I'd appreciate your feedback.

  4. pkulikov commented on Mar 15, 2018

    @pkulikov
    ContributorAuthor

    @BillWagner the feedback to this page: in is not a contextual keyword, but a reserved modifier, so I wanted to remove contextual word from the first line. The same is true for out keyword

  5. BillWagner commented on Mar 15, 2018

    @BillWagner
    Member

    @pkulikov Thanks for the heads up. I just checked the spec, and both are listed as "keywords", so I'll use that notation in both topics.

  6. BillWagner commented on Mar 16, 2018

    @BillWagner
    Member

    Closing as the build finished correctly and the pages now match.

    PR #4677 address the other concern @pkulikov brought up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions