Skip to content

Revise How to: Use Selected Value... topic to display all XAML #4536

Closed

Description

@rpetrusha

Revise How to: Use Selected Value... topic to display all XAML

General

See Issue #4526

The How to: Use Selected Value, SelectedValuePath, and SelectedItem topic needs to be prevised to present the entire contents of the window1.xaml file. Highlighting should then be used to indicate the individual parts that are discussed in the topic.

The code also needs to be modified, as PR #4526 suggests, and the text modified to more clearly explain the code.

@ManGupt @BillWagner

Activity

  1. ManGupt commented on Mar 2, 2018

    @ManGupt

    I agree with @BillWagner on updating the XAML code. Here is my suggestion:
    changing <HierarchicalDataTemplate DataType="EmployeeInfo"
    to <HierarchicalDataTemplate x:Key="SampleTemplate" DataType="EmployeeInfo"
    and
    changing <TreeView ItemsSource.../>
    to <TreeView ItemTemplate="{StaticResource SampleTemplate}" ItemsSource.../>

    What do you think?

  2. added this to the Backlog milestone on Mar 3, 2018
  3. ManGupt commented on Mar 4, 2018

    @ManGupt

    @rpetrusha I would love to do the modification. Just guide me as I am new.

  4. BillWagner commented on Mar 13, 2018

    @BillWagner
    Member

    @ManGupt I just noticed your previous comment. Most of our team was involved with the MVP summit last week, and missed some GitHub notifications.

    What can we do to help you get started?

  5. ManGupt commented on Mar 15, 2018

    @ManGupt

    How do I download the code "samples/snippets/csharp/VS_Snippets_Wpf/TreeViewSelectedValue/CS" to check the changes that I have made?

  6. ManGupt commented on Mar 15, 2018

    @ManGupt

    How can I add reviewers to my pull request #4662 ?

  7. svick commented on Mar 15, 2018

    @svick
    Member

    @ManGupt

    How do I download the code "samples/snippets/csharp/VS_Snippets_Wpf/TreeViewSelectedValue/CS" to check the changes that I have made?

    You have to download the whole repository and then find the directory there. To download the repository, you have two choices:

    1. Use git. This is the common approach that lets you keep an up-to-date local copy of the repository and also perform other operations.

      To do this, go to the main page of the repository, click Clone or download and either select Open in … if you want to use one of the offered choices of git client (like GitHub Desktop) or copy the URL and use it in your git client. If you're using git command line interface, the command to use would be git clone https://github.com/dotnet/docs.git.

    2. Download a ZIP archive of the repository. This is not commonly used and makes sense only if you need access to a copy of the repository rarely.

      To do this, go to the main page of the repository, click Clone or download and select Download ZIP.

    How can I add reviewers to my pull request #4662 ?

    I believe you can't actually add reviewers in a way GitHub would recognize (you would need "write access" to do that). GitHub already automatically added @BillWagner as a reviewer, because he's the "code owner" for C# samples.

    If you want to notify someone else, you can add a comment to your Pull Request, mentioning the user with a @ before their user name. It's also common to indicate that you're notifying someone of the PR by using cc: (which is a convention coming from email). So, if I wanted to notify you, I would write cc: @ManGupt.

  8. removed this from the Backlog milestone on Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedGood for community contributors to help [up-for-grabs]

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions