Skip to content

Fix issue running under netcore 2.0 - #2248

Merged
vicancy merged 2 commits into
dotnet:devfrom
vicancy:ff
Dec 1, 2017
Merged

Fix issue running under netcore 2.0#2248
vicancy merged 2 commits into
dotnet:devfrom
vicancy:ff

Conversation

@vicancy

@vicancy vicancy commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Fix #1752 (comment)

  1. Add necessary env, use dotnet --info to get current default dotnet base path
  2. Add config settings, according to https://github.com/Microsoft/msbuild/blob/6851538897f5d7b08024a6d8435bc44be5869e53/src/Build/Definition/ToolsetReader.cs#L294, config settings takes over registry and over local assembly version.

@superyyrrzz superyyrrzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vicancy
vicancy merged commit 7e5802e into dotnet:dev Dec 1, 2017
@vicancy
vicancy deleted the ff branch December 1, 2017 04:06
vicancy added a commit that referenced this pull request Dec 1, 2017
* Fix issue running under netcore 2.0

* catch exception with dotnet --info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants