Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspecting an argument in the debugger can initialize its cached arity before the argument has been added to a command or given a default value. Later parsing then uses the premature value and can report a missing required argument.
Add a debugger proxy that computes the displayed arity without caching it. Explicitly configured and already initialized arities are displayed as stored, while the normal
Aritygetter retains its existing behavior. The proxy also exposes the argument's metadata and the existing validator and completion collections without initializing them.Fixes #2704.
Validation: the two regression cases for inspection before configuration failed before the fix. All 14 argument tests now pass, including explicit and previously initialized arity cases. The tests instantiate the proxy selected by
DebuggerTypeProxyAttributeand verify subsequent parsing; no manual IDE debugger session was performed. A Windows Debug solution build completed with no warnings or errors, and all five test assemblies passed (1,949 passed, 14 existing skips), including the main tests on .NET 10 and .NET Framework 4.7.2. Release, Linux, and macOS were not run locally.