Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command validators currently run before results are created for omitted options and arguments with default values. Calling
GetValuefrom a validator therefore returns the type's default (for example,0) instead of the configuredDefaultValueFactoryvalue.Create implicit default results for the selected command and its ancestors before running command validators. The factories are still evaluated on demand and cached by the existing conversion path. Validator ordering and the behavior of invalid explicit inputs are unchanged. Results are not created for unselected commands.
Fixes #2841.
Tests cover default and explicit option values, defaults inherited from a parent command, argument defaults, dependencies between defaults, implicit-result flags, and factory evaluation boundaries. Four regression cases failed before the fix. The Windows Debug solution build completed with no warnings or errors, and all five test assemblies passed: 1,957 passed, 14 existing skips, including the main suites on .NET 10 and .NET Framework 4.7.2. Release, Linux, and macOS were not run locally.