Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing fails, the built-in help and typo suggestions are written to standard output while the error itself goes to standard error. This mixes diagnostics with output redirected to another command or file.
Write built-in help to
InvocationConfiguration.Errorwhen the parse result has errors, and send typo suggestions to the same stream. Explicit--helpcontinues to use standard output. Custom help actions are still invoked as before, and the caller's output writer is not changed.Fixes #2840.
Validation: four new regression cases failed before the fix because diagnostics reached standard output. The 53 help, error-reporting, and typo-correction tests pass after the fix. A Windows Debug solution build completed with no warnings or errors; all five test assemblies passed (1,951 passed, 14 existing skips), including the main tests on .NET 10 and .NET Framework 4.7.2. Release, Linux, and macOS were not run locally.