This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Repository navigation
Changing verbose to verbosity in the help options - #6690
Merged
livarcocc merged 1 commit intoMay 30, 2017
Merged
Conversation
Author
|
@dotnet-bot Test OSX10.12 x64 Release Build |
ghost
self-requested a review
May 25, 2017 20:35
dsplaisted
reviewed
May 25, 2017
|
|
||
| {LocalizableStrings.CommonOptions}: | ||
| -v|--verbose {LocalizableStrings.VerboseDefinition} | ||
| -v|--verbosity {LocalizableStrings.VerboseDefinition} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ghost
approved these changes
May 25, 2017
livarcocc
force-pushed
the
fix_verbosity_option_in_help
branch
from
May 30, 2017 20:05
7fcb724 to
c27b89d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tually use.
Customer scenario
Changing verbose to verbosity in the help options to match what we actually use. Without this, after typing dotnet --help a user may see verbose as the way to indicate verbosity to our commands, but in fact, that is not used anymore and the new way to do that is --verbosity. This is misleading and confusing to our users.
Bugs this fixes
Fixes https://github.com/dotnet/cli/issues/5502
Workarounds, if any
N/A
Risk
N/A
Performance impact
N/A
Root cause analysis
The big help text is not composed by the parser, but hand crafted. We have plans to add that to the parser, but not yet.
How was the bug found?
Report by team member.
@dotnet/dotnet-cli
@MattGertz for approval.