Support transitive P2P references

[ViktorHofer]

When enabling project restore in dotnet/runtime, transitive dependencies are now resolved but the hook is missing the TargetFramework.Sdk to annotate/filter them.

Port of aa4285b#diff-65c01698b75e00dac00a586ec65bace1 from the old config system.

[Anipik]

@ViktorHofer can you give an example here for better understanding ?

[ViktorHofer]

Sure, I shared the details with you offline in Teams:

C:\git\runtime4\src\libraries>dotnet msbuild C:\git\runtime4\src\libraries\System.Collections\src\System.Collections.csproj /bl
Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

 

C:\Program Files\dotnet\sdk\3.1.101\MSBuild.dll -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,C:\Program Files\dotnet\sdk\3.1.101\dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,C:\Program Files\dotnet\sdk\3.1.101\dotnet.dll -maxcpucount -verbosity:m /bl C:\git\runtime4\src\libraries\System.Collections\src\System.Collections.csproj
C:\Program Files\dotnet\sdk\3.1.101\Microsoft.Common.CurrentVersion.targets(1653,5): error : Project '..\..\System.Private.Uri\src\System.Private.Uri.csproj' targets 'netcoreapp5.0-Windows_NT;netcoreapp5.0-Unix'. It cannot be referenced by a project that targets '.NETCoreApp,Version=v5.0'. [C:\git\runtime4\src\libraries\System.Collections\src\System.Collections.csproj]

System.Collections references System.Runtime which references System.Private.Uri. Now that we enable restore for these projects, more targets run because the ProjectAssetsFile exists. The additional project reference from System.Collections to System.Private.Uri comes from the "IncludeTransitiveProjectReferences" target:

[Anipik]

apologies. Teams on my mac weirds strangely :). The messages are quite delayed