Skip to content

Bump the manifestmerger-dependencies group in /src/manifestmerger with 2 updates - #12554

Merged
jonathanpeppers merged 1 commit into
mainfrom
dependabot/gradle/src/manifestmerger/manifestmerger-dependencies-efbb7c8895
Aug 31, 2026
Merged

Bump the manifestmerger-dependencies group in /src/manifestmerger with 2 updates#12554
jonathanpeppers merged 1 commit into
mainfrom
dependabot/gradle/src/manifestmerger/manifestmerger-dependencies-efbb7c8895

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 28, 2026

Copy link
Copy Markdown
Contributor

Bumps the manifestmerger-dependencies group in /src/manifestmerger with 2 updates: com.android.tools.build:manifest-merger and com.android.tools:common.

Updates com.android.tools.build:manifest-merger from 32.3.1 to 32.3.2

Updates com.android.tools:common from 32.3.1 to 32.3.2

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the manifestmerger-dependencies group in /src/manifestmerger with 2 updates: com.android.tools.build:manifest-merger and com.android.tools:common.


Updates `com.android.tools.build:manifest-merger` from 32.3.1 to 32.3.2

Updates `com.android.tools:common` from 32.3.1 to 32.3.2

---
updated-dependencies:
- dependency-name: com.android.tools.build:manifest-merger
  dependency-version: 32.3.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: manifestmerger-dependencies
- dependency-name: com.android.tools:common
  dependency-version: 32.3.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: manifestmerger-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file. java Pull requests that update Java code labels Aug 28, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file. java Pull requests that update Java code labels Aug 28, 2026
@jonathanpeppers

jonathanpeppers commented Aug 31, 2026

Copy link
Copy Markdown
Member

OK to merge. The failing CheckSignApk(False,False,NativeAOT) test is unrelated to this dependency update. A Windows test-state leak leaves JAVA_HOME pointing at the temporary JDK created by TestResolveToolsExists, so apksigner.bat cannot start. The same failure reproduced on the job rerun and is not caused by the manifest-merger changes.

@jonathanpeppers
jonathanpeppers merged commit bb3a8f6 into main Aug 31, 2026
42 of 44 checks passed
@jonathanpeppers
jonathanpeppers deleted the dependabot/gradle/src/manifestmerger/manifestmerger-dependencies-efbb7c8895 branch August 31, 2026 14:02
jonathanpeppers added a commit that referenced this pull request Sep 1, 2026
## Description

`DebuggingTasksTests.TestResolveToolsExists` invokes `ResolveXamarinAndroidTools` with temporary Android and Java SDK directories. On Windows, `AndroidSdkWindows.Initialize()` updates process-level `JAVA_HOME` and `PATH`, and `AndroidSdk.Refresh()` leaves shared SDK state pointing at the temporary fixtures. After those directories are deleted, later tests such as `PackagingTest.CheckSignApk(False,False,NativeAOT)` can launch Android tooling with the stale JDK path.

Capture the real SDK paths and original process environment immediately before task execution. A focused `try`/`finally` around the two task calls restores `AndroidSdk`, `JAVA_HOME`, and `PATH`; the existing test setup and cache assertions remain otherwise unchanged.

This is a standalone fix for the deterministic Windows CI contamination observed in PR #12554 build 1571801; it does not modify or depend on the Dependabot change.

## Testing

- `dotnet-local.cmd build src\Xamarin.Android.Build.Tasks\Tests\Xamarin.Android.Build.Tests\Xamarin.Android.Build.Tests.csproj -v:quiet`
- `dotnet-local.cmd test bin\TestDebug\net10.0\Xamarin.Android.Build.Tests.dll --filter "Name~TestResolveToolsExists" -v:quiet`

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant