Repository navigation
Change file map link to absolute path to retire filemap_share_depots - #581
Merged
Merged
Conversation
cheenamalhotra
approved these changes
May 29, 2020
cheenamalhotra
left a comment
Member
There was a problem hiding this comment.
I compared the changes to dotnet-api-docs and LGTM.
We don't have a review site in this repository so we'll know the difference when we attempt to publish docs for review in sqlclient-api-docs repository.
cheenamalhotra
pushed a commit
that referenced
this pull request
Jul 24, 2020
Following of #581 Clean up one more file map link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are retiring filemap_share_depots in OPS build.
Similar change in dotnet-api-docs for reference: dotnet/dotnet-api-docs#4248