Repository navigation
Clarify OneBranch localization validation under failOnValidationError - #4838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The authoritative OneBranch guidance still incorrectly states that non-official validation defaults to strict mode.
1 open finding
What changed in this PR
Defaults non-official OneBranch validation to report-only while preserving strict official validation.
Changes:
- Adds configurable localization resource and allowlist selection.
- Adds allowlist-isolation tests.
- Documents validation behavior.
| File | Description |
|---|---|
BUILDGUIDE.md |
Documents validation policy. |
build-buildproj-job.yml |
Supplies driver localization inputs. |
validate-localization-step.yml |
Adds explicit localization parameters. |
validate-localization.ps1 |
Selects configurable allowlist sections. |
validate-localization.Tests.ps1 |
Tests section isolation and errors. |
sqlclient-non-official.yml |
Defaults validation to report-only. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 task
paulmedynski
added this pull request to stack #4839
October 13, 2026 17:45
This was referenced Oct 13, 2026
paulmedynski
changed the title
paulmedynski
added a commit
that referenced
this pull request
Oct 13, 2026
Keep report-only validation as an explicit queue-time opt-out and align the build guide and OneBranch guidance with the strict default. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
paulmedynski
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
cheenamalhotra
requested changes
Oct 13, 2026
cheenamalhotra
left a comment
cheenamalhotra
left a comment
Member
There was a problem hiding this comment.
How are these changes related to AOT again? Please don't mix terms/feature names with changes that have no links.
This should be an independent PR outside of the AOT stack.
github-project-automation
Bot
moved this from To triage
to Waiting for customer
in SqlClient Board
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.01
branch
from
October 14, 2026 10:49
0bc372e to
6037e56
Compare
Contributor
Author
The sqlclient-non-official pipelines cannot be run successfully without these changes because we have new unlocalized strings on main. I'm fine to split this work out as long as sqlclient-non-official runs successfully on main, which it didn't at the time the stack was created. |
Keep validation strict by default and document the report-only option. Resource-owner generalization belongs to the Abstractions localization PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.01
branch
from
October 14, 2026 11:36
6037e56 to
e5462ae
Compare
paulmedynski
removed this pull request from stack #4839
October 14, 2026 11:39
paulmedynski
changed the title
paulmedynski
changed the title
Address Copilot feedback by wrapping the validation-policy paragraph without changing its wording or behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benrr101
approved these changes
Oct 14, 2026
benrr101
left a comment
benrr101
left a comment
Contributor
There was a problem hiding this comment.
This definitely is not P0, but alright
cheenamalhotra
approved these changes
Oct 14, 2026
github-project-automation
Bot
moved this from Waiting for customer
to Done
in SqlClient Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify that OneBranch localization validation participates in the shared
failOnValidationErrorflag.