Repository navigation
Remove RID-specific SqlClient DLLs - #4673
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 17, 2026
priyankatiwari08
previously approved these changes
Sep 23, 2026
priyankatiwari08
left a comment
priyankatiwari08
left a comment
Contributor
There was a problem hiding this comment.
Looks good - nuspec now serves the implementation from lib/{tfm} and drops the duplicated runtimes/{rid} copies; the ref project multi-targets net462 so the net462 XML source switch resolves, and nothing else in the repo depends on the runtimes/ layout.
paulmedynski
requested changes
Sep 23, 2026
github-project-automation
Bot
moved this from To triage
to Waiting for customer
in SqlClient Board
This is being handled by a separate PR
paulmedynski
approved these changes
Sep 24, 2026
paulmedynski
left a comment
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
Looks great - thanks!
cheenamalhotra
added
the
Public API 🆕
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4673 +/- ##
==========================================
- Coverage 71.88% 64.35% -7.54%
==========================================
Files 290 285 -5
Lines 45056 68063 +23007
==========================================
+ Hits 32389 43800 +11411
- Misses 12667 24263 +11596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Oct 1, 2026
paulmedynski
added a commit
that referenced
this pull request
Oct 1, 2026
Merging main brought in #4673 (Remove RID-specific SqlClient DLLs), which deleted every runtimes/ entry from the SqlClient nuspec. The new TestCommon.Internals project still pointed its Package-mode HintPath at runtimes/win/lib/<tfm>, which no longer exists. Because ExcludeAssets="compile" drops the ref assembly, this left no resolvable SqlClient reference and broke Package-mode builds with MSB3245 followed by CS0234. Point the HintPath at lib/<tfm>, matching the fix #4673 applied to UnitTests.csproj, and drop the @todo hack comment that PR also removed, since the RID-specific binaries it referred to no longer exist. Verified by packing the driver from this commit (0 runtimes/ entries) and building TestCommon.Internals in Package mode for net8.0 and net9.0, plus the consuming UnitTests project. Reverting the HintPath reproduces MSB3245. Addresses Copilot review feedback on PR #4765. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I'm removing the now-vestigial
runtimes/[rid]/lib/[tfm]package paths. The binaries are always identical, so having one copy per RID no longer adds any value. A follow-up PR will deal with thenotsupportedproject - that's probably going to be much larger, and I don't want the user-facing impact to get lost. Since that project is going to be removed anyway, I've also left its unnecessary TFM targets in situ.I'm pushing this fix early to make sure it lands in 8.0.0 preview 1 and gets as much testing exposure as possible.
Issues
Contributes to #4239.
Fixes #903.
Fixes #3006.
Fixes #3577.
Testing
Unit tests run locally. I can reference the output nupkg via a netfx project which still uses packages.config, and by loading the DLL in
lib/net462in PowerShell.