Skip to content

Transient Fault Handling is disabled by default with SqlConnection.OpenAsync() #1982

Closed
#1983
Closed
Transient Fault Handling is disabled by default with SqlConnection.OpenAsync()#1982
#1983

Description

@cheenamalhotra
cheenamalhotra
opened on Apr 5, 2023

Describe the bug

When opening a connection with SqlConnection.OpenAsync(), transient fault handling is not enabled.
Test with placing breakpoints on below locations:

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

Line 1859 in a5ad838

_applyTransientFaultHandling = (!overrides.HasFlag(SqlConnectionOverrides.OpenWithoutRetry) && retry == null && connectionOptions != null && connectionOptions.ConnectRetryCount > 0);

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

Line 1888 in a5ad838

_applyTransientFaultHandling = (retry == null && connectionOptions != null && connectionOptions.ConnectRetryCount > 0);

_applyTransientFaultHandling is set to false as retry is not null in this method when opening connection asynchronously.
When opening connection with Open(), _applyTransientFaultHandling is set to true as expected.

Activity

  1. JRahnama
    added
    untriaged
    on Apr 5, 2023

  2. David-Engel commented on Apr 7, 2023

    @David-Engel
    David-Engel
    on Apr 7, 2023
    Contributor

    Thanks for filing the issue and submitting a PR for the fix!

  3. JRahnama
    removed
    untriaged
    on Apr 12, 2023
  4. DavoudEshtehari
    linked a pull request that will close this issueFix Transient fault handling issue with OpenAsync #1983on Apr 14, 2023
  5. Kaur-Parminder
    closed this as completedin #1983on Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions