Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Implement NuGet V2 Feed support - #64

Merged
KirillOsenkov merged 5 commits into
dotnet:masterfrom
passuied:feature/support-for-nuget-v2
Jan 9, 2020
Merged

KirillOsenkov merged 5 commits into
dotnet:masterfrom
passuied:feature/support-for-nuget-v2

Conversation

@passuied

@passuied passuied commented Jul 7, 2019

Copy link
Copy Markdown

Implement NuGet V2 Feed support.

  • Added some unit tests. These cannot be run when signing is on at the moment.
  • Needs way to up version

@dnfclas

dnfclas commented Jul 7, 2019 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@passuied

passuied commented Jul 7, 2019

Copy link
Copy Markdown
Author

This PR should resolve issue: #59

- Changed WebRequestFactory to use static HttpClient to avoid connection socket exhaustion

@mlorbetske mlorbetske left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the change to the for loop (and maybe converting the other tests to xUnit to not mix frameworks) looks great. Thanks for contributing this. @madskristensen, can you merge and release when ready? Thanks

@passuied passuied left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madskristensen @jaredpar please review and approve PR whenever possible. Installed the change locally and working seamlessly on our nuget v2 feeds hosted in NuGet.Server

@madskristensen

Copy link
Copy Markdown
Collaborator

I can release when @jaredpar or someone with admin rights merges it

@passuied

Copy link
Copy Markdown
Author

@madskristensen @jaredpar Following up on this? How can we find out who is an admin on this repo?
Thanks,
Patrick

@passuied

passuied commented Aug 1, 2019 •

Copy link
Copy Markdown
Author

@madskristensen. I understand you don't have admin privileges but not sure who does and how to find out. Does it mean this PR will never get merged? Please advise

@madskristensen

Copy link
Copy Markdown
Collaborator

@jaredpar @davkean @Pilchie do any of you know who owns this repo and can help look at the PR?

@Pilchie

Pilchie commented Aug 1, 2019

Copy link
Copy Markdown
Member

Adding @jjmew and @panopiconcentral and @jmarolf

@jmarolf

jmarolf commented Aug 1, 2019

Copy link
Copy Markdown

I am not an admin for this repo either. I assume someone in @mlorbetske 's org is?

@jaredpar

jaredpar commented Aug 1, 2019

Copy link
Copy Markdown
Member

Started an email to figure this out. Will add you all.

@passuied

Copy link
Copy Markdown
Author

@loic-sharma are you an admin on the repo?
Are you able to merge it?

@loic-sharma

Copy link
Copy Markdown

I only commented because I'm familiar with the NuGet protocol. I'm not an admin and I don't know who is, sorry 😞

@passuied

passuied commented Aug 12, 2019 via email

Copy link
Copy Markdown
Author

@passuied

Copy link
Copy Markdown
Author

@jaredpar any update on repo admin search?

@passuied

Copy link
Copy Markdown
Author

@jaredpar @madskristensen it's been another 3 months. Any way to fork the repo and move the build to new repo?

@KirillOsenkov
KirillOsenkov merged commit 088368a into dotnet:master Jan 9, 2020
@KirillOsenkov

Copy link
Copy Markdown
Member

Turns out I have the rights to merge PRs. Apologies for the delay and thanks for the contribution!

@passuied

passuied commented Jan 10, 2020 via email

Copy link
Copy Markdown
Author

@passuied
passuied deleted the feature/support-for-nuget-v2 branch January 10, 2020 22:24
@passuied

Copy link
Copy Markdown
Author

@KirillOsenkov @jaredpar @madskristensen who could trigger a build to release new version?

@KirillOsenkov

Copy link
Copy Markdown
Member

@madskristensen is busy this week but next week hopefully we will find time to create a new CI that can sign the VSIX and publish. The old CI for this repo was before Azure DevOps so we'll need to create a pipeline for Azure DevOps to revive this. Thanks for your patience.

@passuied

Copy link
Copy Markdown
Author

@madskristensen @KirillOsenkov any update on updating CI to Azure DevOps?
Please advise,
Patrick

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants